Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(perception_reproducer): deal with detected/tracked objects #3789

Merged

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented May 22, 2023

Description

  • Perception reproducer can publish detected/tracked objects instead of predicted objects
  • Add a document about how to use the script.

Tests performed

planning simulator

Effects on system behavior

Just a change to the tool.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels May 22, 2023
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 added the run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label May 22, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review May 22, 2023 19:04
@takayuki5168 takayuki5168 requested review from taikitanaka3, TakaHoribe and a team as code owners May 22, 2023 19:04
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a3ce54a) 14.12% compared to head (18bd6ac) 14.12%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3789   +/-   ##
=======================================
  Coverage   14.12%   14.12%           
=======================================
  Files        1438     1438           
  Lines      101402   101402           
  Branches    27009    27009           
=======================================
  Hits        14321    14321           
  Misses      71392    71392           
  Partials    15689    15689           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 14.12% <ø> (ø) Carriedforward from a3ce54a

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@takayuki5168 takayuki5168 merged commit 68b6d20 into autowarefoundation:main May 23, 2023
@takayuki5168 takayuki5168 deleted the feat/update-perception-reproducer branch May 23, 2023 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants