fix(avoidance): not init rtc status at onProcessEntry #3804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
github-actions
bot
added
the
component:planning
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3804 +/- ##
=======================================
Coverage 14.11% 14.11%
=======================================
Files 1438 1438
Lines 101421 101420 -1
Branches 27021 27021
=======================================
Hits 14320 14320
+ Misses 71421 71420 -1
Partials 15680 15680
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
satoshi-ota
requested review from
rej55,
kosuke55,
kyoichi-sugahara,
shmpwk,
taikitanaka3,
TakaHoribe,
takayuki5168,
tkimura4,
purewater0901,
zulfaqar-azmi-t4 and
a team
as code owners
purewater0901
approved these changes
May 24, 2023
satoshi-ota
added a commit
to satoshi-ota/autoware.universe
that referenced
this pull request
May 25, 2023
…tion#3804) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota
added a commit
to satoshi-ota/autoware.universe
that referenced
this pull request
Jun 7, 2023
…tion#3804) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota
added a commit
to satoshi-ota/autoware.universe
that referenced
this pull request
Jun 20, 2023
…tion#3804) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jun 23, 2023
…tion#3804) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
tkimura4
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jun 26, 2023
* feat(avoidance): add hysteresis to avoidance necessity check (autowarefoundation#3880) * feat(avoidance): add hysteresis factor to avoid necessity check Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(avoidance_by_lc): add hysteresis factor to avoid necessity check Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(utils): use lambda Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(avoidance): improve stop behavior under decel/jerk constraints option (autowarefoundation#3978) * feat(avoidance): add option to decel within constraints Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * chore(avoidance): add comments Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(utils): merge similar functions Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(avoidance): can set stop/move judge threshold for each object class (autowarefoundation#3998) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(avoidance): ignore behind unavoidable objects (autowarefoundation#4034) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(avoidance): improve avoidance judgement logic for pedestrian & bicycle (autowarefoundation#4016) * feat(avoidance): don't avoid pedestrian and bicycle on crosswalk Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(avoidance): avoid pedestrian/bicycle near centerline Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(utils): use geometry distance Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * chore(avoidance): add comment Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(avoidance): ignore objects less than execution threshold (autowarefoundation#3595) fix(avoidance): ignore objects whose shift length is less than execution threshold Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(avoidance): not init rtc status at onProcessEntry (autowarefoundation#3804) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(avoidance): update logic to keep waiting approval (autowarefoundation#4059) * revert "fix(avoidance): don't clear waiting approval if raw shift line exists (autowarefoundation#4012)" This reverts commit 8577563. * fix(avoidance): update logic to keep waiting approval Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(avoidance): fix invalid cherry pick Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
onProcessEntry()Tests performed
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.