Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(behavior_velocity_planner): update document structure #3916

Merged
merged 3 commits into from
Jun 8, 2023

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jun 7, 2023

Description

update behavior velocity planner's document structure.

Tests performed

No need

Effects on system behavior

Nothing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jun 7, 2023
@takayuki5168 takayuki5168 added run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) and removed type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jun 7, 2023
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jun 7, 2023
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

Documentation URL: https://autowarefoundation.github.io/autoware.universe/pr-3916/
Modified URLs:

@takayuki5168 takayuki5168 requested a review from isamu-takagi June 7, 2023 11:07
@takayuki5168 takayuki5168 marked this pull request as ready for review June 7, 2023 11:07
isamu-takagi
isamu-takagi previously approved these changes Jun 7, 2023
Copy link
Contributor

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the chore/behavior-vel-doc branch from 805cfb2 to 441ef9d Compare June 7, 2023 12:02
@takayuki5168
Copy link
Contributor Author

@shmpwk Could you approve the PR

@TomohitoAndo TomohitoAndo changed the title chore(behavior_velocith_planner): update document structure chore(behavior_velocity_planner): update document structure Jun 7, 2023
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.96 🎉

Comparison is base (35bc65a) 14.05% compared to head (441ef9d) 15.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3916      +/-   ##
==========================================
+ Coverage   14.05%   15.02%   +0.96%     
==========================================
  Files        1456     1350     -106     
  Lines      102521    95901    -6620     
  Branches    27295    27287       -8     
==========================================
- Hits        14411    14408       -3     
+ Misses      72323    65713    -6610     
+ Partials    15787    15780       -7     
Flag Coverage Δ *Carryforward flag
differential 2.70% <ø> (?)
total 15.02% <ø> (+0.96%) ⬆️ Carriedforward from 35bc65a

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
.../rtc_manager_rviz_plugin/src/rtc_manager_panel.cpp 0.00% <ø> (ø)
...viz_plugin/src/velocity_steering_factors_panel.cpp 0.00% <ø> (ø)
...anner/include/behavior_path_planner/parameters.hpp 50.00% <ø> (ø)
...nner/include/behavior_path_planner/utils/utils.hpp 45.45% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 18.66% <ø> (+0.01%) ⬆️
.../scene_module/goal_planner/goal_planner_module.cpp 5.13% <ø> (ø)
...test/test_behavior_path_planner_node_interface.cpp 27.90% <ø> (ø)
...test_utils/src/planning_interface_test_manager.cpp 60.88% <ø> (+0.53%) ⬆️
...de_manager/src/rtc_auto_mode_manager_interface.cpp 0.00% <ø> (ø)
planning/rtc_interface/src/rtc_interface.cpp 14.39% <ø> (+0.10%) ⬆️
... and 2 more

... and 117 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168 takayuki5168 changed the title chore(behavior_velocity_planner): update document structure docs(behavior_velocity_planner): update document structure Jun 8, 2023
@takayuki5168 takayuki5168 merged commit 1e572a8 into autowarefoundation:main Jun 8, 2023
@takayuki5168 takayuki5168 deleted the chore/behavior-vel-doc branch June 8, 2023 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants