fix(occlusion_spot): add lacking param #4290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
satoshi-ota
requested review from
shmpwk,
taikitanaka3 and
tkimura4
as code owners
github-actions
bot
added
the
component:planning
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #4290 +/- ##
=======================================
Coverage 15.20% 15.20%
=======================================
Files 1489 1489
Lines 102682 102682
Branches 31539 31539
=======================================
Hits 15609 15609
Misses 70119 70119
Partials 16954 16954
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
HansRobo
pushed a commit
to HansRobo/autoware.universe
that referenced
this pull request
Jul 18, 2023
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
HansRobo
added a commit
that referenced
this pull request
Jul 18, 2023
* fix(occlusion_spot): add lacking param (#4290) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * chore(cspell): add cspell-partial.json Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * chore(cspell): add spell-check-partial.yaml Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * chore(cspell): fix spell-check-partial Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * style(pre-commit): autofix Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * feat(tier4_autoware_utils): add intersect function (#4312) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * chore(cspell): test spell-check-partial Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * chore(cspell): revert spell-check-partial Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
HansRobo
added a commit
that referenced
this pull request
Jul 18, 2023
* fix(occlusion_spot): add lacking param (#4290) Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * chore(cspell): add cspell-partial.json Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * chore(cspell): add spell-check-partial.yaml Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * chore(cspell): fix spell-check-partial Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * style(pre-commit): autofix Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * feat(tier4_autoware_utils): add intersect function (#4312) Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * chore(cspell): test spell-check-partial Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * chore(cspell): revert spell-check-partial Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> * feat(ci): enable spell-check-partial for map component Signed-off-by: kminoda <koji.minoda@tier4.jp> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Signed-off-by: kminoda <koji.minoda@tier4.jp> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com> Co-authored-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
zhiwango
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Jul 25, 2023
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
zhiwango
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jul 25, 2023
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🤖 Generated by Copilot at 4e74e12
Added new parameters to
occlusion_spot.param.yamlto configure the detection area and search range for the occlusion spot module. This module helps avoid collisions with occluded vehicles.Close #4192
Tests performed
Psim
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.