Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): enable spell-check-partial for map component #4322

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Jul 18, 2023

Description

Enable spell-check-partial for map component.

Related links

N/A

Tests performed

N/A

Notes for reviewers

N/A

Interface changes

N/A

Effects on system behavior

Spell-check-partial would run on map component.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

satoshi-ota and others added 11 commits July 18, 2023 20:05
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
…n#4312)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@github-actions github-actions bot added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Jul 18, 2023
@github-actions github-actions bot removed the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Jul 18, 2023
@kminoda kminoda marked this pull request as ready for review July 18, 2023 12:23
@kminoda kminoda requested a review from HansRobo July 18, 2023 12:23
Copy link
Member

@HansRobo HansRobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HansRobo HansRobo merged commit 665281e into autowarefoundation:main Jul 18, 2023
@kminoda kminoda deleted the feat/enable_spell_check_partial_for_map_component branch August 10, 2023 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants