feat(gnss_poser): options for gnss pose pub method #4357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvzksgl
added
component:sensing
github-actions
bot
added
type:documentation
3 tasks
yvzksgl
added
component:localization
github-actions
bot
added
type:documentation
yvzksgl
added
component:localization
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4357 +/- ##
==========================================
+ Coverage 15.06% 15.08% +0.01%
==========================================
Files 1508 1508
Lines 103769 103593 -176
Branches 31702 31578 -124
==========================================
- Hits 15629 15622 -7
+ Misses 71122 70981 -141
+ Partials 17018 16990 -28
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
YamatoAndo
changed the title
github-actions
bot
added
type:documentation
YamatoAndo
reviewed
Jul 21, 2023
|
I have confirmed that it is working as expected. Once the type mistake is corrected, I will approve this pr. |
|
@YamatoAndo i fixed it, sorry about that. |
yvzksgl
added
the
component:localization
YamatoAndo
approved these changes
Jul 21, 2023
YamatoAndo
added
the
run:build-and-test-differential
kminoda
pushed a commit
to kminoda/autoware.universe
that referenced
this pull request
Jul 24, 2023
…n#4357) * Option for how to publish gnss_pose * Readme updated * style(pre-commit): autofix * typo is corrected * style(pre-commit): autofix --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding feature reffered: #4188
This PR offers three options for publishing gnss_pose:
Tests performed
All added options runned through logging simulator.
Effects on system behavior
Different GNSS/INS sensors different accuracies, user should be able to choose the most suitable buffer size and gnss pose publish method for themselves.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The Reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.