Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(image_projection_based_fusion): change to throttle log #4572

Merged

Conversation

mkuri
Copy link
Contributor

@mkuri mkuri commented Aug 8, 2023

Description

Fix from RCLCPP_WARN to RCLCPP_WARN_THROTTLE because other logs are not visible on the console

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Aug 8, 2023
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkuri mkuri added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 9, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04% ⚠️

Comparison is base (9ac8faf) 14.80% compared to head (36c662c) 14.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4572      +/-   ##
==========================================
- Coverage   14.80%   14.77%   -0.04%     
==========================================
  Files        1527     1532       +5     
  Lines      105673   105907     +234     
  Branches    32107    32107              
==========================================
  Hits        15649    15649              
- Misses      72945    73179     +234     
  Partials    17079    17079              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.80% <ø> (+<0.01%) ⬆️ Carriedforward from 9ac8faf

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
.../image_projection_based_fusion/src/fusion_node.cpp 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkuri mkuri changed the title fix(image_projection_based_fusion): fix to throttle log chore(image_projection_based_fusion): fix to throttle log Aug 9, 2023
@mkuri mkuri changed the title chore(image_projection_based_fusion): fix to throttle log chore(image_projection_based_fusion): change to throttle log Aug 9, 2023
@mkuri mkuri merged commit cdd5ec8 into autowarefoundation:main Aug 9, 2023
mkuri added a commit to mkuri/autoware.universe that referenced this pull request Aug 10, 2023
…efoundation#4572)

* fix(image_projection_based_fusion): fix to throttle log

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>

* style(pre-commit): autofix

---------

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
LeoDriveProject pushed a commit to leo-drive/autoware.universe.golf that referenced this pull request Aug 16, 2023
…efoundation#4572)

* fix(image_projection_based_fusion): fix to throttle log

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>

* style(pre-commit): autofix

---------

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants