-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(image_projection_based_fusion): change to throttle log #4572
chore(image_projection_based_fusion): change to throttle log #4572
Conversation
Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4572 +/- ##
==========================================
- Coverage 14.80% 14.77% -0.04%
==========================================
Files 1527 1532 +5
Lines 105673 105907 +234
Branches 32107 32107
==========================================
Hits 15649 15649
- Misses 72945 73179 +234
Partials 17079 17079
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
…efoundation#4572) * fix(image_projection_based_fusion): fix to throttle log Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> * style(pre-commit): autofix --------- Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…efoundation#4572) * fix(image_projection_based_fusion): fix to throttle log Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> * style(pre-commit): autofix --------- Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Description
Fix from RCLCPP_WARN to RCLCPP_WARN_THROTTLE because other logs are not visible on the console
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.