Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(radar_fusion_to_detected_object): fix confidence #4992

Merged

Conversation

scepter914
Copy link
Contributor

@scepter914 scepter914 commented Sep 14, 2023

Description

Fix confidence reference in radar_fusion_to_detected_object.

Tests performed

Test by rosbag

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: scepter914 <scepter914@gmail.com>
@scepter914 scepter914 requested a review from miursh as a code owner September 14, 2023 07:32
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Sep 14, 2023
@scepter914 scepter914 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 14, 2023
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (eded1f1) 15.74% compared to head (0f11647) 15.74%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4992   +/-   ##
=======================================
  Coverage   15.74%   15.74%           
=======================================
  Files        1587     1587           
  Lines      109770   109770           
  Branches    33702    33702           
=======================================
  Hits        17286    17286           
  Misses      73858    73858           
  Partials    18626    18626           
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 15.74% <ø> (+<0.01%) ⬆️ Carriedforward from eded1f1

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ted_object/src/radar_fusion_to_detected_object.cpp 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scepter914 scepter914 merged commit 31dbd2e into autowarefoundation:main Sep 19, 2023
@scepter914 scepter914 deleted the fix/radar_fusion_confidence branch September 19, 2023 02:59
scepter914 added a commit to tier4/autoware.universe that referenced this pull request Sep 19, 2023
scepter914 added a commit to tier4/autoware.universe that referenced this pull request Sep 19, 2023
scepter914 added a commit to tier4/autoware.universe that referenced this pull request Sep 29, 2023
scepter914 added a commit to tier4/autoware.universe that referenced this pull request Sep 29, 2023
miursh pushed a commit to tier4/autoware.universe that referenced this pull request Oct 3, 2023
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants