-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(external_velocity_limit_selector): revert "refactor(external_velocity_limit_selector): rework parameter (#5238)" #6132
Merged
rej55
merged 1 commit into
autowarefoundation:main
from
rej55:revert/rework_parameter_external_velocity_limit_selector
Jan 22, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satoshi-ota
approved these changes
Jan 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6132 +/- ##
=======================================
Coverage 14.60% 14.60%
=======================================
Files 1860 1860
Lines 127418 127418
Branches 37286 37286
=======================================
Hits 18609 18609
Misses 87902 87902
Partials 20907 20907
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rej55
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jan 23, 2024
…city_limit_selector): rework parameter (autowarefoundation#5238)" (autowarefoundation#6132) Revert "refactor(external_velocity_limit_selector): rework parameter (autowarefoundation#5238)" This reverts commit 19dab56.
4 tasks
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Jan 23, 2024
…city_limit_selector): rework parameter (autowarefoundation#5238)" (autowarefoundation#6132) Revert "refactor(external_velocity_limit_selector): rework parameter (autowarefoundation#5238)" This reverts commit 19dab56.
h-ohta
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Feb 8, 2024
…city_limit_selector): rework parameter (autowarefoundation#5238)" (autowarefoundation#6132) Revert "refactor(external_velocity_limit_selector): rework parameter (autowarefoundation#5238)" This reverts commit 19dab56.
4 tasks
0x126
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Feb 13, 2024
…city_limit_selector): rework parameter (autowarefoundation#5238)" (autowarefoundation#6132) (#1135) Revert "refactor(external_velocity_limit_selector): rework parameter (autowarefoundation#5238)" This reverts commit 19dab56. Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
mergify bot
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Apr 18, 2024
…city_limit_selector): rework parameter (autowarefoundation#5238)" (autowarefoundation#6132) (#1135) Revert "refactor(external_velocity_limit_selector): rework parameter (autowarefoundation#5238)" This reverts commit 19dab56. Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com> (cherry picked from commit 07e919b)
4 tasks
karishma1911
pushed a commit
to Interplai/autoware.universe
that referenced
this pull request
Jun 3, 2024
…city_limit_selector): rework parameter (autowarefoundation#5238)" (autowarefoundation#6132) Revert "refactor(external_velocity_limit_selector): rework parameter (autowarefoundation#5238)" This reverts commit 19dab56.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
run:build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
type:documentation
Creating or refining documentation. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reverts commit 19dab56.
Before this change, it does not read config files from following:
autoware.universe/launch/tier4_planning_launch/launch/scenario_planning/scenario_planning.launch.xml
Lines 22 to 23 in f5cef6c
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.