Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(external_velocity_limit_selector): revert "refactor(external_velocity_limit_selector): rework parameter (#5238)" #6132

Conversation

rej55
Copy link
Contributor

@rej55 rej55 commented Jan 22, 2024

Description

This reverts commit 19dab56.

Before this change, it does not read config files from following:

<arg name="common_param_path" value="$(var common_param_path)"/>
<arg name="param_path" value="$(var motion_velocity_smoother_param_path)"/>

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jan 22, 2024
@rej55 rej55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jan 22, 2024
@rej55 rej55 enabled auto-merge (squash) January 22, 2024 06:37
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f5cef6c) 14.60% compared to head (2ade765) 14.60%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6132   +/-   ##
=======================================
  Coverage   14.60%   14.60%           
=======================================
  Files        1860     1860           
  Lines      127418   127418           
  Branches    37286    37286           
=======================================
  Hits        18609    18609           
  Misses      87902    87902           
  Partials    20907    20907           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 14.60% <ø> (ø) Carriedforward from f5cef6c

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rej55 rej55 merged commit d04bb57 into autowarefoundation:main Jan 22, 2024
32 of 34 checks passed
@rej55 rej55 deleted the revert/rework_parameter_external_velocity_limit_selector branch January 23, 2024 05:18
rej55 added a commit to tier4/autoware.universe that referenced this pull request Jan 23, 2024
…city_limit_selector): rework parameter (autowarefoundation#5238)" (autowarefoundation#6132)

Revert "refactor(external_velocity_limit_selector): rework parameter (autowarefoundation#5238)"

This reverts commit 19dab56.
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jan 23, 2024
…city_limit_selector): rework parameter (autowarefoundation#5238)" (autowarefoundation#6132)

Revert "refactor(external_velocity_limit_selector): rework parameter (autowarefoundation#5238)"

This reverts commit 19dab56.
h-ohta pushed a commit to tier4/autoware.universe that referenced this pull request Feb 8, 2024
…city_limit_selector): rework parameter (autowarefoundation#5238)" (autowarefoundation#6132)

Revert "refactor(external_velocity_limit_selector): rework parameter (autowarefoundation#5238)"

This reverts commit 19dab56.
0x126 pushed a commit to tier4/autoware.universe that referenced this pull request Feb 13, 2024
…city_limit_selector): rework parameter (autowarefoundation#5238)" (autowarefoundation#6132) (#1135)

Revert "refactor(external_velocity_limit_selector): rework parameter (autowarefoundation#5238)"

This reverts commit 19dab56.

Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
mergify bot pushed a commit to tier4/autoware.universe that referenced this pull request Apr 18, 2024
…city_limit_selector): rework parameter (autowarefoundation#5238)" (autowarefoundation#6132) (#1135)

Revert "refactor(external_velocity_limit_selector): rework parameter (autowarefoundation#5238)"

This reverts commit 19dab56.

Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
(cherry picked from commit 07e919b)
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
…city_limit_selector): rework parameter (autowarefoundation#5238)" (autowarefoundation#6132)

Revert "refactor(external_velocity_limit_selector): rework parameter (autowarefoundation#5238)"

This reverts commit 19dab56.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants