Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(emergency_handler): fix dead link in readme #644

Merged
merged 5 commits into from
Apr 15, 2022
Merged

docs(emergency_handler): fix dead link in readme #644

merged 5 commits into from
Apr 15, 2022

Conversation

angry-crab
Copy link
Contributor

@angry-crab angry-crab commented Apr 6, 2022 •
edited by kenji-miyake
Loading

Signed-off-by: Xinyu Wang xinyu.wang@tier4.jp

Description

Dead link in emergency_handler.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@angry-crab angry-crab linked an issue Apr 6, 2022 that may be closed by this pull request
Dead link in emergency_handler #635
Closed
3 tasks
kenji-miyake
kenji-miyake previously approved these changes Apr 6, 2022
View reviewed changes
@kenji-miyake kenji-miyake changed the title fix(emergency_handler): dead link in readme docs(emergency_handler): dead link in readme Apr 6, 2022
@kenji-miyake kenji-miyake changed the title docs(emergency_handler): dead link in readme docs(emergency_handler): fix dead link in readme Apr 6, 2022
@kenji-miyake
Copy link
Contributor

@angry-crab Since this won't fix any feature, I changed the title to docs.

@codecov
Copy link

codecov bot commented Apr 6, 2022 •
edited
Loading

Codecov Report

Merging #644 (7d920c1) into main (7681249) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #644   +/-   ##
=======================================
  Coverage   10.59%   10.59%           
=======================================
  Files         735      735           
  Lines       51755    51755           
  Branches     6596     6596           
=======================================
  Hits         5482     5482           
  Misses      41813    41813           
  Partials     4460     4460
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 10.59% <0.00%> (ø) Carriedforward from 2ca9de7

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ption_rviz_plugin/src/tools/interactive_object.cpp 0.00% <0.00%> (ø)
...ption_rviz_plugin/src/tools/interactive_object.hpp 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d5834d...7d920c1. Read the comment docs.

docs(emergency_handler): fix dead link in readme
0df72e4 
Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>
@angry-crab angry-crab force-pushed the 635-dead-link-in-emergency_handler branch from b29a57d to 0df72e4 Compare April 6, 2022 09:14
@kenji-miyake kenji-miyake mentioned this pull request Apr 7, 2022
Closed
3 tasks
@xmfcx xmfcx self-requested a review April 12, 2022 07:57
13304490790 pushed a commit to 13304490790/autoware.universe that referenced this pull request Apr 12, 2022
@tkimura4 @KeisukeShima
@kmiya @kenji-miyake @YoheiMishina @taikitanaka3
feat: add fault_injection packages (autowarefoundation#101)
f391dd7 
* Add fault injection package (autowarefoundation#1760)

* add fault injection package

* fix copyright url

* fix for lint

* pre-commit fixed

* change license note

* separate functions for responsivity

* add tests

* add compile option

* Remove unnecessary descriptions

* Update the readme

* Replace png with svg

* Remove the constructor to follow the recommendations

* Remove amant_clang_format to match the standard

* Change the using statement to clarify the type

* Add using to shorten the type

* lint

* change variable name

* Rename input and delete output

* sort lines

* use range-based for

* added const

* Remove temporary variables

* Set an empty value to get all parameters

* change filename

* Move test files to test directory

* Remove unused lines

* fix to add reference symbol

* add read_parameter.launch.py

* remove unused option

* add comment

* Change input type to autoware_simulation_msgs

* refactoring: move parameter function to parameter_handler

* refactoring

* remove key_storage

* replace data with simulation_events

* remove temporary variable

* reflects the opinions of review

* change order

* delete template

* change event name

* reflect review request

* remove &

* change constructor argument

* delete unused function

* change to event_diag_map class

* changes for review

* fix build error

* fix test error

* refactor launch_test

* replace logging with launch.logging

reason: launch.logging supports verbose output option.
i.e. launch_test -v FILE

* merge update function

* rename callback function

* move using line

* add node name as hardware id

* fix comment

* change return value

* add menber to DiagConfig

* sort menber order

* use to_yaml

* remove const

* change function order

* rename getValue() to getDiag()

* add isEventRegistered function

* move test

* modify script

* delete else

* change cond

* use docstring style

* move msg_buffer

* rename

* rename

* fix

* fix

* fix

* use emplace_back

* add isEventRegistered

* fix build error

* remove destroy_sub,pub

* change check statement

* add comment

* fix build error

* use leveltype

* fair test

* change spin time

* restore config

* add node name

* shorten name

* change function name

* remove read_parameter

* expand timeout

* comment out launch_test

* Fix a broken link of the component diagram on Fault Injection document (autowarefoundation#2202)

* [Fault injection] Update component diagram (autowarefoundation#2203)

* Update component diagram

* Rename pSim to scenario_simulator_v2

* fix upload error

* Transparent background

* Fix line widths of the component diagram on Fault Injection document (autowarefoundation#2205)

* Feature/add fault injection settings (autowarefoundation#2199)

* add parameter file

* add message

* Change formatter to clang-format and black (autowarefoundation#2332)

* Revert "Temporarily comment out pre-commit hooks"

This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3.

* Replace ament_lint_common with autoware_lint_common

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Remove ament_cmake_uncrustify and ament_clang_format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply Black

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix for cpplint

* Fix include double quotes to angle brackets

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Apply clang-format

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Fix build errors

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* Add COLCON_IGNORE (autowarefoundation#500)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* remove colcon_ignore in fault injection (autowarefoundation#585)

* update readme in fault injection (autowarefoundation#644)

* Update readme in fault_injection

* fix precommit

Co-authored-by: Keisuke Shima <19993104+KeisukeShima@users.noreply.github.com>
Co-authored-by: Kazuki Miyahara <kmiya@outlook.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: Yohei Mishina <66298900+YoheiMishina@users.noreply.github.com>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
@kenji-miyake kenji-miyake enabled auto-merge (squash) April 15, 2022 10:13
@kenji-miyake kenji-miyake merged commit 1e829e2 into main Apr 15, 2022
@kenji-miyake kenji-miyake deleted the 635-dead-link-in-emergency_handler branch April 15, 2022 10:13
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Apr 16, 2022
Merged
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
@angry-crab @boyali
docs(emergency_handler): fix dead link in readme (tier4#644)
f2b682c 
* docs(emergency_handler): fix dead link in readme

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>

* save image to local

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@angry-crab @boyali
docs(emergency_handler): fix dead link in readme (tier4#644)
606d6a4 
* docs(emergency_handler): fix dead link in readme

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>

* save image to local

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
@angry-crab @boyali
docs(emergency_handler): fix dead link in readme (tier4#644)
f565e0b 
* docs(emergency_handler): fix dead link in readme

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>

* save image to local

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
@angry-crab @boyali
docs(emergency_handler): fix dead link in readme (tier4#644)
c413d39 
* docs(emergency_handler): fix dead link in readme

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>

* save image to local

Signed-off-by: Xinyu Wang <xinyu.wang@tier4.jp>
1222-takeshi pushed a commit to 1222-takeshi/autoware.universe that referenced this pull request Jul 26, 2023
@tier4-autoware-public-bot
Merge pull request autowarefoundation#644 from tier4/sync-upstream
11890ea 
chore: sync upstream
ryuichi-maeda pushed a commit to sensefield/autoware.universe that referenced this pull request Jan 10, 2025
@dependabot @tkimura4 @h-ohta
chore(deps): bump actions/checkout from 3 to 4 (autowarefoundation#644)
03020af 
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tomoya Kimura <tomoya.kimura@tier4.jp>
Co-authored-by: Hiroki OTA <hiroki.ota@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenji-miyake kenji-miyake kenji-miyake approved these changes

@meliketanrikulu meliketanrikulu Awaiting requested review from meliketanrikulu

@xmfcx xmfcx Awaiting requested review from xmfcx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dead link in emergency_handler
2 participants
@angry-crab @kenji-miyake