-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(elevation_map_loader)!: fix namespace and directory structure #7807
refactor(elevation_map_loader)!: fix namespace and directory structure #7807
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@technolojin could you also make the changes to rename the package and the directory? It's easier to review if it's all in one go. Thanks.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7807 +/- ##
==========================================
- Coverage 28.66% 28.65% -0.01%
==========================================
Files 1588 1589 +1
Lines 116375 116393 +18
Branches 49696 49701 +5
==========================================
Hits 33358 33358
- Misses 73925 73943 +18
Partials 9092 9092
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
As I mentioned in autowarefoundation/autoware#4569 (comment), I will do it in separated PRs |
I feel that splitting the PR is not particularly problematic for me. |
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
b2e507c
to
08d34fd
Compare
@esteve Can you response on this topic? |
@technolojin we'll discuss this in the ASWG, because the process the perception team at TierIV is following regardin this task doesn't seem to be aligned with what we agreed originally, see https://github.com/orgs/autowarefoundation/discussions/4097#discussioncomment-9234315 As @TakaHoribe said, the Autoware project shouldn't be limited in what it can do or not just because of one company (in this case, TierIV) |
Description
This PR puts headers in the
autoware
namespace.Additional works
Related links
Part of: autowarefoundation/autoware#4569
How was this PR tested?
Tested in a local recompute environment and the TIER IV Cloud environment.
TIER IV INTERNAL
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.