Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(elevation_map_loader)!: fix namespace and directory structure #7807

Conversation

technolojin
Copy link
Contributor

Description

This PR puts headers in the autoware namespace.

Additional works

  1. Align directory structure to follow the coding guidelines.
  2. Clean unused dependencies LIST

Related links

Part of: autowarefoundation/autoware#4569

How was this PR tested?

Tested in a local recompute environment and the TIER IV Cloud environment.
TIER IV INTERNAL

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jul 3, 2024
Copy link

github-actions bot commented Jul 3, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 3, 2024
@technolojin technolojin marked this pull request as ready for review July 3, 2024 10:03
Copy link
Contributor

@esteve esteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@technolojin could you also make the changes to rename the package and the directory? It's easier to review if it's all in one go. Thanks.

@esteve esteve enabled auto-merge (squash) July 3, 2024 11:33
@esteve esteve disabled auto-merge July 3, 2024 11:33
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.65%. Comparing base (b233929) to head (08d34fd).
Report is 10 commits behind head on main.

Files Patch % Lines
...ation_map_loader/src/elevation_map_loader_node.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7807      +/-   ##
==========================================
- Coverage   28.66%   28.65%   -0.01%     
==========================================
  Files        1588     1589       +1     
  Lines      116375   116393      +18     
  Branches    49696    49701       +5     
==========================================
  Hits        33358    33358              
- Misses      73925    73943      +18     
  Partials     9092     9092              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 28.66% <ø> (+<0.01%) ⬆️ Carriedforward from b233929

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@technolojin
Copy link
Contributor Author

@technolojin could you also make the changes to rename the package and the directory? It's easier to review if it's all in one go. Thanks.

As I mentioned in autowarefoundation/autoware#4569 (comment), I will do it in separated PRs

@yukkysaito
Copy link
Contributor

As I mentioned in autowarefoundation/autoware#4569 (comment), I will do it in separated PRs

I feel that splitting the PR is not particularly problematic for me.

technolojin and others added 3 commits July 5, 2024 15:23
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@technolojin technolojin force-pushed the refactor/namespace-elevation_map_loader branch from b2e507c to 08d34fd Compare July 5, 2024 06:23
@technolojin
Copy link
Contributor Author

@esteve Can you response on this topic?

@technolojin technolojin requested a review from esteve July 9, 2024 02:29
@esteve
Copy link
Contributor

esteve commented Jul 9, 2024

@technolojin we'll discuss this in the ASWG, because the process the perception team at TierIV is following regardin this task doesn't seem to be aligned with what we agreed originally, see https://github.com/orgs/autowarefoundation/discussions/4097#discussioncomment-9234315

As @TakaHoribe said, the Autoware project shouldn't be limited in what it can do or not just because of one company (in this case, TierIV)

@technolojin technolojin deleted the refactor/namespace-elevation_map_loader branch July 11, 2024 05:34
@technolojin technolojin restored the refactor/namespace-elevation_map_loader branch July 12, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants