-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: remove unused <depend>
in package.xml files
#3606
Draft
VRichardJP
wants to merge
18
commits into
autowarefoundation:main
Choose a base branch
from
VRichardJP:clean_package_xml
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VRichardJP
requested review from
taikitanaka3,
a team,
TakaHoribe,
1222-takeshi,
tkimura4,
ito-san,
kenji-miyake,
asana17,
mkuri,
isamu-takagi,
tkhmy,
yabuta,
mitsudome-r,
yukkysaito,
KeisukeShima,
scepter914,
miursh,
amc-nu,
YamatoAndo,
badai-nguyen,
satoshi-ota,
kosuke55,
takayuki5168,
rej55,
shmpwk,
purewater0901,
zulfaqar-azmi-t4,
maxime-clem,
kyoichi-sugahara and
soblin
as code owners
May 2, 2023 07:49
This was referenced Jun 28, 2024
This was referenced Jul 5, 2024
This was referenced Jul 12, 2024
This was referenced Jul 12, 2024
knzo25
removed request for
a team,
knzo25,
kenji-miyake,
tkhmy,
purewater0901,
1222-takeshi,
asana17 and
angry-crab
October 9, 2024 07:33
This pull request has been automatically marked as stale because it has not had recent activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:common
Common packages from the autoware-common repository. (auto-assigned)
component:control
Vehicle control algorithms and mechanisms. (auto-assigned)
component:evaluator
Evaluation tools for planning, localization etc. (auto-assigned)
component:localization
Vehicle's position determination in its environment. (auto-assigned)
component:map
Map creation, storage, and loading. (auto-assigned)
component:perception
Advanced sensor data processing and environment understanding. (auto-assigned)
component:planning
Route planning, decision-making, and navigation. (auto-assigned)
component:sensing
Data acquisition from sensors, drivers, preprocessing. (auto-assigned)
component:simulation
Virtual environment setups and simulations. (auto-assigned)
component:system
System design and integration. (auto-assigned)
component:vehicle
Vehicle-specific implementations, drivers, packages. (auto-assigned)
status:stale
Inactive or outdated issues. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleaned all unused
<depend>
reported by the ad-hocunused_deps.sh
script.In most cases, removing the
<depend>
line is enough. But sometimes downstream packages are impacted and must add the missing dependency.Sometimes
<depend>
are just<build_depend>
or<test_depend>
.Related links
autowarefoundation/autoware#3468
Tests performed
Can compile with tests and run demo with the planning simulator.
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.