Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tensorrt_classifier)!: fix namespace and directory structure #8009

Merged
merged 14 commits into from
Jul 22, 2024
Merged

refactor(tensorrt_classifier)!: fix namespace and directory structure #8009

merged 14 commits into from
Jul 22, 2024

Conversation

MasatoSaeki
Copy link
Contributor

@MasatoSaeki MasatoSaeki commented Jul 12, 2024 •
edited
Loading

Description

This PR puts headers in the autoware namespace.

Additional works

  1. Align directory structure to follow the coding guidelines.
  2. Clean unused dependencies LIST

Related links

Part of: autowarefoundation/autoware#4569

How was this PR tested?

I tested by traffic light recognition of driving log replayer. And confirmed that there was no change in accuracy or behavior.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@MasatoSaeki
add prefix into
b8f09bb 
Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
@MasatoSaeki
add prefix in CODEOWNERS
101f8f2 
Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
@MasatoSaeki
remove invalid author
b3facdf 
Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) labels Jul 12, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 12, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@MasatoSaeki MasatoSaeki changed the title refactor(tensorrt_classifier): fix namespace and directory structure refactor(tensorrt_classifier)!: fix namespace and directory structure Jul 12, 2024
@MasatoSaeki MasatoSaeki marked this pull request as ready for review July 17, 2024 07:38
@yukkysaito
Copy link
Contributor

Tested in a local recompute environment.

Could you please describe the tests you performed?

@MasatoSaeki
Copy link
Contributor Author

@yukkysaito
I tested by traffic light recognition of driving log replayer. And confirmed that there was no change in accuracy or behavior.

@yukkysaito
Copy link
Contributor

@MasatoSaeki
Could you write it down here?

image

@MasatoSaeki
Copy link
Contributor Author

@yukkysaito
I did it.

yukkysaito
yukkysaito approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MasatoSaeki MasatoSaeki enabled auto-merge (squash) July 19, 2024 10:26
@MasatoSaeki MasatoSaeki disabled auto-merge July 22, 2024 00:37
@MasatoSaeki
Merge remote-tracking branch 'origin/main' into refactor/tensorrt_cla…
2d04569 
…ssifier/autoware_prefix
@MasatoSaeki
for ci
90c5b16 
Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
@MasatoSaeki MasatoSaeki enabled auto-merge (squash) July 22, 2024 00:56
@MasatoSaeki MasatoSaeki added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 22, 2024
@MasatoSaeki MasatoSaeki merged commit c4d75b3 into autowarefoundation:main Jul 22, 2024
30 of 32 checks passed
Ariiees pushed a commit to Ariiees/autoware.universe that referenced this pull request Jul 22, 2024
@MasatoSaeki @pre-commit-ci @Ariiees
refactor(tensorrt_classifier)!: fix namespace and directory structure (…
dec06c5 
…autowarefoundation#8009)

* add prefix  into

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>

* add prefix in CODEOWNERS

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>

* remove invalid author

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>

* style(pre-commit): autofix

* add prefix

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>

* style(pre-commit): autofix

* ci

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>

* for ci

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>

---------

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
chihungtzeng pushed a commit to chihungtzeng/autoware.universe that referenced this pull request Jul 23, 2024
@MasatoSaeki @pre-commit-ci
refactor(tensorrt_classifier)!: fix namespace and directory structure (…
ef88122 
…autowarefoundation#8009)

* add prefix  into

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>

* add prefix in CODEOWNERS

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>

* remove invalid author

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>

* style(pre-commit): autofix

* add prefix

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>

* style(pre-commit): autofix

* ci

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>

* for ci

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>

---------

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jul 23, 2024
@MasatoSaeki @pre-commit-ci @kyoichi-sugahara
refactor(tensorrt_classifier)!: fix namespace and directory structure (…
4e97055 
…autowarefoundation#8009)

* add prefix  into

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>

* add prefix in CODEOWNERS

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>

* remove invalid author

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>

* style(pre-commit): autofix

* add prefix

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>

* style(pre-commit): autofix

* ci

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>

* for ci

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>

---------

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
@MasatoSaeki @pre-commit-ci @esteve
refactor(tensorrt_classifier)!: fix namespace and directory structure (…
8768485 
…autowarefoundation#8009)

* add prefix  into

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>

* add prefix in CODEOWNERS

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>

* remove invalid author

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>

* style(pre-commit): autofix

* add prefix

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>

* style(pre-commit): autofix

* ci

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>

* for ci

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>

---------

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@MasatoSaeki MasatoSaeki deleted the refactor/tensorrt_classifier/autoware_prefix branch August 27, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yukkysaito yukkysaito yukkysaito approved these changes

@ktro2828 ktro2828 ktro2828 approved these changes

@miursh miursh Awaiting requested review from miursh miursh is a code owner

@tzhong518 tzhong518 Awaiting requested review from tzhong518

Assignees
No one assigned
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MasatoSaeki @yukkysaito @ktro2828