-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(radar_scan_to_pointcloud2): fix namespace and directory structure #7912
refactor(radar_scan_to_pointcloud2): fix namespace and directory structure #7912
Conversation
…cture Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…akeLists.txt Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7912 +/- ##
==========================================
- Coverage 28.44% 28.43% -0.02%
==========================================
Files 1591 1592 +1
Lines 116213 116271 +58
Branches 49613 49618 +5
==========================================
Hits 33059 33059
- Misses 74141 74199 +58
Partials 9013 9013
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(Note: without checking acting, after integrating with other PRs and checking acting this PR can be merged)
…cture (autowarefoundation#7912) * refactor(radar_scan_to_pointcloud2): fix namespace and directory structure Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> * refactor(radar_scan_to_pointcloud2): add PCL dependency and update CMakeLists.txt Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp> --------- Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Description
This PR puts headers in the
autoware
namespace.Additional works
Related links
Part of: autowarefoundation/autoware#4569
How was this PR tested?
Tested in a local recompute environment and the TIER IV Cloud environment.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.