Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(radar_scan_to_pointcloud2): fix namespace and directory structure #7912

Conversation

technolojin
Copy link
Contributor

@technolojin technolojin commented Jul 9, 2024

Description

This PR puts headers in the autoware namespace.

Additional works

  1. Align directory structure to follow the coding guidelines.
  2. Clean unused dependencies LIST

Related links

Part of: autowarefoundation/autoware#4569

How was this PR tested?

Tested in a local recompute environment and the TIER IV Cloud environment.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

…cture

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
…akeLists.txt

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
@github-actions github-actions bot added the component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) label Jul 9, 2024
Copy link

github-actions bot commented Jul 9, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@technolojin technolojin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 9, 2024
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.43%. Comparing base (6d0247e) to head (44ca257).
Report is 3 commits behind head on main.

Files Patch % Lines
...pointcloud2/src/radar_scan_to_pointcloud2_node.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7912      +/-   ##
==========================================
- Coverage   28.44%   28.43%   -0.02%     
==========================================
  Files        1591     1592       +1     
  Lines      116213   116271      +58     
  Branches    49613    49618       +5     
==========================================
  Hits        33059    33059              
- Misses      74141    74199      +58     
  Partials     9013     9013              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 28.44% <ø> (ø) Carriedforward from 6d0247e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@technolojin technolojin marked this pull request as ready for review July 10, 2024 01:27
Copy link
Contributor

@scepter914 scepter914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
(Note: without checking acting, after integrating with other PRs and checking acting this PR can be merged)

@technolojin technolojin merged commit 651d75b into autowarefoundation:main Jul 10, 2024
41 checks passed
@technolojin technolojin deleted the refactor/namespace-radar_scan_to_pointcloud2 branch July 11, 2024 05:34
Ariiees pushed a commit to Ariiees/autoware.universe that referenced this pull request Jul 22, 2024
…cture (autowarefoundation#7912)

* refactor(radar_scan_to_pointcloud2): fix namespace and directory structure

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

* refactor(radar_scan_to_pointcloud2): add PCL dependency and update CMakeLists.txt

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>

---------

Signed-off-by: Taekjin LEE <taekjin.lee@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants