Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tier4_perception_rviz_plugin): modify build error in rolling #791

Merged
merged 2 commits into from
Apr 25, 2022
Merged

fix(tier4_perception_rviz_plugin): modify build error in rolling #791

merged 2 commits into from
Apr 25, 2022

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented Apr 24, 2022

Description

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@wep21 wep21 requested review from kenji-miyake and esteve April 24, 2022 18:41
@wep21 wep21 added ros:rolling Continuous ROS Rolling Ridley release. ros:humble ROS Humble Hawksbill release. labels Apr 24, 2022
kenji-miyake
kenji-miyake previously approved these changes Apr 25, 2022
wep21 added 2 commits April 25, 2022 11:21
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #791 (34753b9) into main (ad492f8) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main    #791      +/-   ##
========================================
- Coverage   9.63%   9.63%   -0.01%     
========================================
  Files        907     907              
  Lines      56544   56547       +3     
  Branches    6694    6694              
========================================
  Hits        5448    5448              
- Misses     46601   46604       +3     
  Partials    4495    4495              
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 9.63% <0.00%> (ø) Carriedforward from ad492f8

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ption_rviz_plugin/src/tools/interactive_object.hpp 0.00% <ø> (ø)
...lision_checker_node/obstacle_collision_checker.cpp 0.00% <ø> (ø)
...tacle_stop_planner/src/adaptive_cruise_control.cpp 0.00% <0.00%> (ø)
...lanning/obstacle_stop_planner/src/debug_marker.cpp 0.00% <ø> (ø)
planning/obstacle_stop_planner/src/node.cpp 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2af223e...34753b9. Read the comment docs.

@wep21 wep21 enabled auto-merge (squash) April 25, 2022 02:44
@wep21 wep21 requested a review from kenji-miyake April 25, 2022 02:44
@wep21 wep21 merged commit b91a7fa into autowarefoundation:main Apr 25, 2022
@wep21 wep21 deleted the fix/rolling-tier4-perception-rviz-plugin branch April 25, 2022 04:03
h-ohta referenced this pull request in h-ohta/autoware.universe Apr 26, 2022
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
h-ohta referenced this pull request in h-ohta/autoware.universe Apr 26, 2022
…ring (#235)

* add delay steer vel in psim

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* change wz to steer

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix param description

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* modify readme

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* modify cmake

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* ci: change file URL

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix: order to create callback (#220)

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* chore: remove unnecessary depends (#227)

* ci: add check-build-depends.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* chore: simplify build_depends.repos

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* chore: remove exec_depend

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* chore: use register-autonomoustuff-repository

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* chore: add setup tasks to other workflows

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* ci: update .yamllint.yaml (#229)

* ci: update .yamllint.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* chore: fix for yamllint

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix: remove warning for compile error (#198)

* fix: fix compile error of pointcloud preprocessor

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix: fix compiler warning for had map utils

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix: fix compiler warning for behavior velocity planner

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix: fix compiler warning for compare map segmentation

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix: fix compiler warning for occupancy grid map outlier filter

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix: fix compiler warning for detection by tracker

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix: restore comment

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix: set control_mode false before autoware engage (#232)

* fix: set control_mode false before autoware engage

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* add input/engage remap in launch

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix: library path (#225)

Signed-off-by: taikitanaka3 <taiki.tanaka@tier4.jp>

Co-authored-by: taikitanaka3 <taiki.tanaka@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix: interpolation (#791) (#218)

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* add missing function definition in .cpp

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* set input and state for DELAY_STEER_VEL model

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fix: fix typo

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

Co-authored-by: Kenji Miyake <kenji.miyake@tier4.jp>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
Co-authored-by: taikitanaka3 <taiki.tanaka@tier4.jp>
Co-authored-by: Tomoya Kimura <tomoya.kimura@tier4.jp>
taikitanaka3 referenced this pull request in tier4/autoware.universe Jun 27, 2022
* fix(tier4_perception_rviz_plugin): modify build error in rolling

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix(tier4_perception_rviz_plugin): add target compile definitions

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
taikitanaka3 referenced this pull request in tier4/autoware.universe Jun 27, 2022
* fix(tier4_perception_rviz_plugin): modify build error in rolling

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix(tier4_perception_rviz_plugin): add target compile definitions

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
tkimura4 referenced this pull request in tier4/autoware.universe Jun 27, 2022
* feat(tier4_perception_rviz_plugin): interactive pedestrian for rviz plugin (#534)

* feat(tier4_perception_rviz_plugin): add mouse event util function

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(tier4_perception_rviz_plugin): delete option for QT

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(tier4_perception_rviz_plugin): remove interactive_pedestrian.cpp

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(tier4_perception_rviz_plugin): expand conventional 2D dummy pedestrian to be able to interact

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(tier4_perception_rviz_plugin): change for void

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(tier4_perception_rviz_plugin): not use std::numeric_limits::epsilon()

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(tier4_perception_rviz_plugin): plugin supports interactive manipulation for dummy CAR & UNKNOWN object (#554)

* fix(tier4_perception_rviz_plugin): split pedestrian.hpp(cpp) into two parts

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(tier4_perception_rviz_plugin): modify logic of velocity & pose calculation

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(tier4_perception_rviz_plugin): plugin supports 2D Interactive dummy car

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* feat(tier4_perception_rviz_plugin): plugin supports 2D Interactive unknown object

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor(tier4_perception_rviz_plugin): use common class

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(tier4_perception_rviz_plugin): fix dummy pedestrian shape (#571)

* fix(tier4_perception_rviz_plugin): set interactive object velocity to zero on releasing the object (#686)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(tier4_perception_rviz_plugin): modify build error in rolling (#791)

* fix(tier4_perception_rviz_plugin): modify build error in rolling

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix(tier4_perception_rviz_plugin): add target compile definitions

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* feat(perception_rviz_plugin): add 2d dummy bus with height (#903)

* feat(perception_rviz_plugin): add 2d dummy bus with height

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* ci(pre-commit): autofix

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Co-authored-by: Satoshi OTA <44889564+satoshi-ota@users.noreply.github.com>
Co-authored-by: Takeshi Miura <57553950+1222-takeshi@users.noreply.github.com>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
alanmengg pushed a commit to alanmengg/autoware.universe that referenced this pull request Sep 24, 2022
…owarefoundation#791)

* fix(tier4_perception_rviz_plugin): modify build error in rolling

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix(tier4_perception_rviz_plugin): add target compile definitions

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Signed-off-by: guiping meng <alan.meng@autocore.ai>
alanmengg added a commit to alanmengg/autoware.universe that referenced this pull request Sep 24, 2022
…ing (autowarefoundation#791)"

This reverts commit eac57fb.

Signed-off-by: guiping meng <alan.meng@autocore.ai>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
…r4#791)

* fix(tier4_perception_rviz_plugin): modify build error in rolling

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix(tier4_perception_rviz_plugin): add target compile definitions

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…r4#791)

* fix(tier4_perception_rviz_plugin): modify build error in rolling

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix(tier4_perception_rviz_plugin): add target compile definitions

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
shmpwk pushed a commit that referenced this pull request Oct 3, 2022
…g#980 (#1872)

* fix(tier4_perception_rviz_plugin): modify build error in rolling (#791)

* fix(tier4_perception_rviz_plugin): modify build error in rolling

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix(tier4_perception_rviz_plugin): add target compile definitions

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Signed-off-by: guiping meng <alan.meng@autocore.ai>

* fix(had_map_utils): modify build error in rolling (#782)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Signed-off-by: guiping meng <alan.meng@autocore.ai>

* fix: modify build error of ndt related packages in rolling (#793)

* fix(ndt_pcl_modified): modify build error in rolling

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix(ndt): modify build error in rolling

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix(ndt_scan_matcher): modify build error in rolling

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* ci(pre-commit): autofix

* remove unused find_package

* fix(ndt): remove memory.h

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: guiping meng <alan.meng@autocore.ai>

* fix(freespace_planner):  Can't stop before blocking obstacle in parking #980

Signed-off-by: guiping meng <alan.meng@autocore.ai>

* ci(pre-commit): autofix

Signed-off-by: guiping meng <alan.meng@autocore.ai>

* Update planning/freespace_planner/src/freespace_planner/freespace_planner_node.cpp

Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
Signed-off-by: guiping meng <alan.meng@autocore.ai>

* Revert "fix(had_map_utils): modify build error in rolling (#782)"

This reverts commit 7075fca.

Signed-off-by: guiping meng <alan.meng@autocore.ai>

* Revert "fix: modify build error of ndt related packages in rolling (#793)"

This reverts commit a235363.

Signed-off-by: guiping meng <alan.meng@autocore.ai>

* Update planning/freespace_planner/src/freespace_planner/freespace_planner_node.cpp

    Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
    Signed-off-by: guiping meng <alan.meng@autocore.ai>

Signed-off-by: guiping meng <alan.meng@autocore.ai>

* revert some changes Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>

Signed-off-by: guiping meng <alan.meng@autocore.ai>

* revert some changes Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>

Signed-off-by: guiping meng <alan.meng@autocore.ai>

* ci(pre-commit): autofix

Signed-off-by: guiping meng <alan.meng@autocore.ai>

* revert some changes

Signed-off-by: guiping meng <alan.meng@autocore.ai>

* fix mistakes

Signed-off-by: guiping meng <alan.meng@autocore.ai>

* Revert "fix(tier4_perception_rviz_plugin): modify build error in rolling (#791)"

This reverts commit eac57fb.

Signed-off-by: guiping meng <alan.meng@autocore.ai>

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Signed-off-by: guiping meng <alan.meng@autocore.ai>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
…r4#791)

* fix(tier4_perception_rviz_plugin): modify build error in rolling

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix(tier4_perception_rviz_plugin): add target compile definitions

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
…r4#791)

* fix(tier4_perception_rviz_plugin): modify build error in rolling

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix(tier4_perception_rviz_plugin): add target compile definitions

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
…g#980 (autowarefoundation#1872)

* fix(tier4_perception_rviz_plugin): modify build error in rolling (tier4#791)

* fix(tier4_perception_rviz_plugin): modify build error in rolling

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix(tier4_perception_rviz_plugin): add target compile definitions

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Signed-off-by: guiping meng <alan.meng@autocore.ai>

* fix(had_map_utils): modify build error in rolling (tier4#782)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Signed-off-by: guiping meng <alan.meng@autocore.ai>

* fix: modify build error of ndt related packages in rolling (tier4#793)

* fix(ndt_pcl_modified): modify build error in rolling

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix(ndt): modify build error in rolling

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* fix(ndt_scan_matcher): modify build error in rolling

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* ci(pre-commit): autofix

* remove unused find_package

* fix(ndt): remove memory.h

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: guiping meng <alan.meng@autocore.ai>

* fix(freespace_planner):  Can't stop before blocking obstacle in parking tier4#980

Signed-off-by: guiping meng <alan.meng@autocore.ai>

* ci(pre-commit): autofix

Signed-off-by: guiping meng <alan.meng@autocore.ai>

* Update planning/freespace_planner/src/freespace_planner/freespace_planner_node.cpp

Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
Signed-off-by: guiping meng <alan.meng@autocore.ai>

* Revert "fix(had_map_utils): modify build error in rolling (tier4#782)"

This reverts commit 7075fca.

Signed-off-by: guiping meng <alan.meng@autocore.ai>

* Revert "fix: modify build error of ndt related packages in rolling (tier4#793)"

This reverts commit a235363.

Signed-off-by: guiping meng <alan.meng@autocore.ai>

* Update planning/freespace_planner/src/freespace_planner/freespace_planner_node.cpp

    Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
    Signed-off-by: guiping meng <alan.meng@autocore.ai>

Signed-off-by: guiping meng <alan.meng@autocore.ai>

* revert some changes Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>

Signed-off-by: guiping meng <alan.meng@autocore.ai>

* revert some changes Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>

Signed-off-by: guiping meng <alan.meng@autocore.ai>

* ci(pre-commit): autofix

Signed-off-by: guiping meng <alan.meng@autocore.ai>

* revert some changes

Signed-off-by: guiping meng <alan.meng@autocore.ai>

* fix mistakes

Signed-off-by: guiping meng <alan.meng@autocore.ai>

* Revert "fix(tier4_perception_rviz_plugin): modify build error in rolling (tier4#791)"

This reverts commit eac57fb.

Signed-off-by: guiping meng <alan.meng@autocore.ai>

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Signed-off-by: guiping meng <alan.meng@autocore.ai>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kosuke Takeuchi <kosuke.tnp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ros:humble ROS Humble Hawksbill release. ros:rolling Continuous ROS Rolling Ridley release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants