-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lane_change): revise current lane objects filtering #9785
feat(lane_change): revise current lane objects filtering #9785
Conversation
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
@mkquda |
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9785 +/- ##
==========================================
+ Coverage 28.79% 28.83% +0.03%
==========================================
Files 1455 1455
Lines 109092 108970 -122
Branches 42493 42426 -67
==========================================
+ Hits 31412 31418 +6
+ Misses 74602 74476 -126
+ Partials 3078 3076 -2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Description
Currently when filtering lane change objects, only front moving objects are considered as "current lane objects", which impacts features that rely on the existence of front stopped objects on the current lane (such as maintaining enough distance from stopped object to perform lane change).
Additionally the logic for computing min. distance to current lanes object is not robust and can give incorrect results in some cases.
This PR revises the object filtering to consider stopped front objects for current lane, and fixes the logic in function
get_min_dist_to_current_lanes_obj
.Additionally a parameter is added to enable/disable the feature of keeping a distance from front stopped object to perform lane change.
The image below shows the object filtering result before, you can see that the object inside the current lane is considered as other (orchid color).
The image below shows the object filtering result after, you can see that the object inside the current lane is considered as current_lane (yellow color).
Related links
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
ROS Parameter Changes
Additions and removals
enable_stopped_vehicle_buffer
bool
true
Effects on system behavior
None.