Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lane_change): revise current lane objects filtering #9785

Conversation

mkquda
Copy link
Contributor

@mkquda mkquda commented Dec 25, 2024

Description

Currently when filtering lane change objects, only front moving objects are considered as "current lane objects", which impacts features that rely on the existence of front stopped objects on the current lane (such as maintaining enough distance from stopped object to perform lane change).

Additionally the logic for computing min. distance to current lanes object is not robust and can give incorrect results in some cases.

This PR revises the object filtering to consider stopped front objects for current lane, and fixes the logic in function get_min_dist_to_current_lanes_obj.
Additionally a parameter is added to enable/disable the feature of keeping a distance from front stopped object to perform lane change.

The image below shows the object filtering result before, you can see that the object inside the current lane is considered as other (orchid color).
Screenshot from 2024-12-25 14-12-43

The image below shows the object filtering result after, you can see that the object inside the current lane is considered as current_lane (yellow color).
Screenshot from 2024-12-25 14-10-36

Related links

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

ROS Parameter Changes

Additions and removals

Change type Parameter Name Type Default Value Description
Added enable_stopped_vehicle_buffer bool true If true, will keep enough distance from current lane front stopped object to perform lane change when possible

Effects on system behavior

None.

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Dec 25, 2024
Copy link

github-actions bot commented Dec 25, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@mkquda mkquda added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 25, 2024
@zulfaqar-azmi-t4
Copy link
Contributor

@mkquda
Please include launcher PR's link as well 🫡

Signed-off-by: mohammad alqudah <alqudah.mohammad@tier4.jp>
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 35.71429% with 9 lines in your changes missing coverage. Please review.

Project coverage is 28.83%. Comparing base (231c341) to head (caab6ce).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...havior_path_lane_change_module/src/utils/utils.cpp 0.00% 7 Missing ⚠️
...are_behavior_path_lane_change_module/src/scene.cpp 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9785      +/-   ##
==========================================
+ Coverage   28.79%   28.83%   +0.03%     
==========================================
  Files        1455     1455              
  Lines      109092   108970     -122     
  Branches    42493    42426      -67     
==========================================
+ Hits        31412    31418       +6     
+ Misses      74602    74476     -126     
+ Partials     3078     3076       -2     
Flag Coverage Δ *Carryforward flag
differential 20.93% <35.71%> (?)
total 28.83% <ø> (+0.03%) ⬆️ Carriedforward from 0997af5

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mkquda mkquda merged commit 7e3a80c into autowarefoundation:main Dec 27, 2024
35 of 36 checks passed
@mkquda mkquda deleted the RT1-8920-revise-current-lane-objects-filtering branch December 27, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants