Add zip bomb tests #1300
Merged
Add zip bomb tests #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
March 2, 2023 15:34
…o-internal into add-zstd-compression
StephenButtolph
requested review from
abi87,
danlaine,
gyuho,
hexfusion and
joshua-kim
as code owners
danlaine
reviewed
Apr 6, 2023
| // Make sure that we didn't allocate significantly more memory than | ||
| // the max message size. | ||
| bytesAllocatedDuringDecompression := afterDecompressionStats.TotalAlloc - beforeDecompressionStats.TotalAlloc | ||
| require.Less(t, bytesAllocatedDuringDecompression, uint64(10*maxMessageSize)) |
There was a problem hiding this comment.
Kinda interesting that you have to make this at least 6 to pass 🤔
There was a problem hiding this comment.
It's just because of how the underlying bytes buffer grows afaict.
danlaine
approved these changes
Apr 6, 2023
joshua-kim
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Verifies that our decompression is not vulnerable to a zip bomb attack.
How this works
Attempts to decompress pre-generated zip bombs. It verifies that decompressing the bombs doesn't crash and that it doesn't allocate significantly more memory than an expected message size.
How this was tested
It is a test