Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add zip bomb tests #1300

Merged
merged 85 commits into from
Apr 6, 2023
Merged

Add zip bomb tests #1300

merged 85 commits into from
Apr 6, 2023

Commits on Mar 2, 2023

  1. WIP

    Dan Laine committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    0b089ef View commit details
    Browse the repository at this point in the history

  2. remove max size from NewZstdCompressor

    Dan Laine committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    e4e513b View commit details
    Browse the repository at this point in the history

  3. WIP support multiple compression types

    Dan Laine committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    ef84d36 View commit details
    Browse the repository at this point in the history

  4. rename compressionType to Type

    Dan Laine committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    4a659b0 View commit details
    Browse the repository at this point in the history

  5. fix metric

    Dan Laine committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    c6de927 View commit details
    Browse the repository at this point in the history

  6. WIP remove CompressionEnabled and add --network-compression-type

    Dan Laine committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    13eb890 View commit details
    Browse the repository at this point in the history

  7. rename types

    Dan Laine committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    bc55ea4 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2023

  1. add zstd compression/decompression metrics

    Dan Laine committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    400a918 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/dev' into add-zstd-compression

    Dan Laine committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    6f8bd3e View commit details
    Browse the repository at this point in the history

  3. don't allow 2 network compression flags

    Dan Laine committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    38e7a12 View commit details
    Browse the repository at this point in the history

  4. remove benchmark

    Dan Laine committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    3850c79 View commit details
    Browse the repository at this point in the history

  5. cleanup

    Dan Laine committed Mar 3, 2023
    Configuration menu
    Copy the full SHA
    6065be8 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2023

  1. don't use zstd until v1.10

    Dan Laine committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    d7c5d52 View commit details
    Browse the repository at this point in the history

  2. tweak error message

    Dan Laine committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    385ba27 View commit details
    Browse the repository at this point in the history

  3. nit

    Dan Laine committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    37bcf39 View commit details
    Browse the repository at this point in the history

  4. nits

    Dan Laine committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    81afb71 View commit details
    Browse the repository at this point in the history

  5. nits

    Dan Laine committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    4da5f21 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2023

  1. Merge remote-tracking branch 'origin/dev' into add-zstd-compression

    Dan Laine committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    d8a9ccf View commit details
    Browse the repository at this point in the history

  2. flag wording nit

    Dan Laine committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    d9b778c View commit details
    Browse the repository at this point in the history

  3. add zstd tests; fix bugs

    Dan Laine committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    41bc6c5 View commit details
    Browse the repository at this point in the history

  4. consolidate metrics

    Dan Laine committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    11c171d View commit details
    Browse the repository at this point in the history

  5. remove old todo

    Dan Laine committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    ddd35ee View commit details
    Browse the repository at this point in the history

  6. update test

    Dan Laine committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    6dd3f25 View commit details
    Browse the repository at this point in the history

  7. update tests

    Dan Laine committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    eab4879 View commit details
    Browse the repository at this point in the history

  8. add tests

    Dan Laine committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    1ad19c1 View commit details
    Browse the repository at this point in the history

  9. appease linter

    Dan Laine committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    6b29cfc View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2023

  1. Merge branch 'dev' into add-zstd-compression

    Dan Laine authored Mar 13, 2023
    Configuration menu
    Copy the full SHA
    7c150cd View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. Merge remote-tracking branch 'origin/dev' into add-zstd-compression

    Dan Laine committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    874632a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'add-zstd-compression' of github.com:ava-labs/avalancheg… 

    …o-internal into add-zstd-compression
    Dan Laine committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    a9a96f6 View commit details
    Browse the repository at this point in the history

  3. nits

    Dan Laine committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    9526ba9 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'dev' into add-zstd-compression

    Dan Laine authored Mar 15, 2023
    Configuration menu
    Copy the full SHA
    e1f0d55 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2023

  1. Merge branch 'dev' into add-zstd-compression

    Dan Laine authored Mar 21, 2023
    Configuration menu
    Copy the full SHA
    c000a83 View commit details
    Browse the repository at this point in the history

  2. use default compression type in tests

    Dan Laine committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    483f040 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'add-zstd-compression' of github.com:ava-labs/avalancheg… 

    …o-internal into add-zstd-compression
    Dan Laine committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    041c37e View commit details
    Browse the repository at this point in the history

  4. flag nit

    Dan Laine committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    6b3f9a3 View commit details
    Browse the repository at this point in the history

  5. only allow zstd after cortina

    Dan Laine committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    5325c6b View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2023

  1. Merge remote-tracking branch 'upstream/dev' into add-zstd-compression

    Dan Laine committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    4345b1e View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2023

  1. merged

    @StephenButtolph
    StephenButtolph committed Apr 2, 2023
    Configuration menu
    Copy the full SHA
    51d3cbb View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2023

  1. Merge remote-tracking branch 'upstream/dev' into add-zstd-compression

    Dan Laine committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    9dc7108 View commit details
    Browse the repository at this point in the history

  2. address PR comments

    Dan Laine committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    b401ea6 View commit details
    Browse the repository at this point in the history

  3. remove switch

    Dan Laine committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    b0225da View commit details
    Browse the repository at this point in the history

  4. Merge branch 'add-zstd-compression' of github.com:ava-labs/avalancheg… 

    …o into add-zstd-compression
    Dan Laine committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    45d9b3f View commit details
    Browse the repository at this point in the history

  5. add max message size test

    Dan Laine committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    8472760 View commit details
    Browse the repository at this point in the history

  6. add max message size to zstd

    Dan Laine committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    0e61411 View commit details
    Browse the repository at this point in the history

  7. add test

    Dan Laine committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    32d8d37 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'upstream/dev' into add-zstd-compression

    Dan Laine committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    72a0b7c View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2023

  1. remove switch

    Dan Laine committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    db6504a View commit details
    Browse the repository at this point in the history

  2. use stream interface for Decompress to avoid unzip bomb

    Dan Laine committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    53df4c6 View commit details
    Browse the repository at this point in the history

  3. fix copy pasta bug

    Dan Laine committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    adbc82a View commit details
    Browse the repository at this point in the history

  4. move switch case to default

    Dan Laine committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    e510398 View commit details
    Browse the repository at this point in the history

  5. remove impossible switch case

    Dan Laine committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    82d7f68 View commit details
    Browse the repository at this point in the history

  6. appease linter

    Dan Laine committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    bdcf189 View commit details
    Browse the repository at this point in the history

  7. make reader a local var

    Dan Laine committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    b91159d View commit details
    Browse the repository at this point in the history

  8. return nit

    Dan Laine committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    c259199 View commit details
    Browse the repository at this point in the history

  9. add invalid max size check to zstd compressor creation

    Dan Laine committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    9105741 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'dev' into add-zstd-compression

    @StephenButtolph
    StephenButtolph authored Apr 4, 2023
    Configuration menu
    Copy the full SHA
    8ad8fe6 View commit details
    Browse the repository at this point in the history

  11. Parallelize gzip compression

    @StephenButtolph
    StephenButtolph committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    eaec3ef View commit details
    Browse the repository at this point in the history

  12. merged

    @StephenButtolph
    StephenButtolph committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    c6c6fdf View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2023

  1. log warning for unknown op during metrics observation

    Dan Laine committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    c6f4800 View commit details
    Browse the repository at this point in the history

  2. use sync.Pool of gzip writer

    Dan Laine committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    8ad1cb6 View commit details
    Browse the repository at this point in the history

  3. gzipWriter.Flush() --> gzipWriter.Close()

    Dan Laine committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    8c499af View commit details
    Browse the repository at this point in the history

  4. test cleanup

    Dan Laine committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    812a37d View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'upstream/add-zstd-compression' into sim… 

    …plify-gzip-compression
    Dan Laine committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    084be58 View commit details
    Browse the repository at this point in the history

  6. appease linter

    Dan Laine committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    a0c1dda View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'upstream/add-zstd-compression' into sim… 

    …plify-gzip-compression
    Dan Laine committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    c1d7a98 View commit details
    Browse the repository at this point in the history

  8. remove magic number

    Dan Laine committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    26e7235 View commit details
    Browse the repository at this point in the history

  9. Merge remote-tracking branch 'upstream/add-zstd-compression' into sim… 

    …plify-gzip-compression
    Dan Laine committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    f3f7785 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'dev' into add-zstd-compression

    @StephenButtolph
    StephenButtolph authored Apr 5, 2023
    Configuration menu
    Copy the full SHA
    a2cc314 View commit details
    Browse the repository at this point in the history

  11. imports nit

    @StephenButtolph
    StephenButtolph committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    436685b View commit details
    Browse the repository at this point in the history

  12. Merge remote-tracking branch 'upstream/add-zstd-compression' into sim… 

    …plify-gzip-compression
    Dan Laine committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    d30e0a9 View commit details
    Browse the repository at this point in the history

  13. nit

    @StephenButtolph
    StephenButtolph committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    b40e14b View commit details
    Browse the repository at this point in the history

  14. test nits

    Dan Laine committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    0c0a396 View commit details
    Browse the repository at this point in the history

  15. Merge remote-tracking branch 'upstream/add-zstd-compression' into sim… 

    …plify-gzip-compression
    Dan Laine committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    422a840 View commit details
    Browse the repository at this point in the history

  16. nits

    @StephenButtolph
    StephenButtolph committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    0fca08a View commit details
    Browse the repository at this point in the history

  17. nit

    @StephenButtolph
    StephenButtolph committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    dfc909d View commit details
    Browse the repository at this point in the history

  18. Merge branch 'add-zstd-compression' into simplify-gzip-compression

    @StephenButtolph
    StephenButtolph authored Apr 5, 2023
    Configuration menu
    Copy the full SHA
    781023e View commit details
    Browse the repository at this point in the history

  19. Add zipbomb tests

    @StephenButtolph
    StephenButtolph committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    e769d97 View commit details
    Browse the repository at this point in the history

  20. nit

    @StephenButtolph
    StephenButtolph committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    c2fe2e4 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2023

  1. merged

    @StephenButtolph
    StephenButtolph committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    e550864 View commit details
    Browse the repository at this point in the history

  2. Embed the zip bombs

    @StephenButtolph
    StephenButtolph committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    dda9596 View commit details
    Browse the repository at this point in the history

  3. nits

    @StephenButtolph
    StephenButtolph committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    65ec891 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'simplify-gzip-compression' into add-zip-bomb-tests

    @StephenButtolph
    StephenButtolph committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    7afff07 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'dev' into simplify-gzip-compression

    @StephenButtolph
    StephenButtolph authored Apr 6, 2023
    Configuration menu
    Copy the full SHA
    0f43f37 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'simplify-gzip-compression' into add-zip-bomb-tests

    @StephenButtolph
    StephenButtolph authored Apr 6, 2023
    Configuration menu
    Copy the full SHA
    a074713 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'dev' into add-zip-bomb-tests

    @StephenButtolph
    StephenButtolph authored Apr 6, 2023
    Configuration menu
    Copy the full SHA
    37ed76c View commit details
    Browse the repository at this point in the history