Consistent variable names

[cam-schultz]

Why this should be merged

Fixes #189

How this works

Renames vars

How this was tested

CI

How is this documented

N/A

[cam-schultz]

The vulnerability reported by Snyk is coming from the avalanche-cli installation in the testing container. It's fixed in the repo, but we'll have to wait for the next avalanche-cli release for this to go away. Since this container is used for testing only, this is not a blocker.

[michaelkaplan13]

There are a few more places that we should update:

[michaelkaplan13]

We should also rename DEFAULT_ORIGIN_BLOCKCHAIN_ID to DEFAULT_SOURCE_BLOCKCHAIN_ID.

[cam-schultz]

There are a few more places that we should update:

We should also rename DEFAULT_ORIGIN_BLOCKCHAIN_ID to DEFAULT_SOURCE_BLOCKCHAIN_ID.

Made these changes.

[michaelkaplan13]

Looks like originChainID is used in a few places still.

[cam-schultz]

Looks like originChainID is used in a few places still.

Whoops, fixed now. I also updated destinationChainID -> destinationBlockchainID

[michaelkaplan13]

Final few nits. In the three cases below, can we update to BlockchainID (either adding the "Block" or lower-casing the C in "Chain")

[cam-schultz]

Final few nits. In the three cases below, can we update to BlockchainID (either adding the "Block" or lower-casing the C in "Chain")

Sure thing. Also renamed getBlockChainId.py -> getBlockchainId.py

[michaelkaplan13]

🚀

[minghinmatthewlam]

LGTM