Reformat & correct the JavaDoc of all constraints #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mechite <contact@mechite.com>
Signed-off-by: Mechite <contact@mechite.com>
|
^ a small proposed amendment |
SentryMan
previously approved these changes
Sep 15, 2025
rbygrave
reviewed
Sep 16, 2025
validator-constraints/src/main/java/io/avaje/validation/constraints/AssertFalse.java
Show resolved
Hide resolved
rbygrave
reviewed
Sep 16, 2025
validator-constraints/src/main/java/io/avaje/validation/constraints/Digits.java
Outdated
Show resolved
Hide resolved
rbygrave
reviewed
Sep 16, 2025
validator-constraints/src/main/java/io/avaje/validation/constraints/NegativeOrZero.java
Outdated
Show resolved
Hide resolved
rbygrave
reviewed
Sep 16, 2025
validator-constraints/src/main/java/io/avaje/validation/constraints/NotEmpty.java
Outdated
Show resolved
Hide resolved
rbygrave
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Question occurred during authoring: Why does
NotBlankhave the#max()field?@SentryMan answered with quote - #103
Reasoning here seems good, but the documentation for this feature seems like it may need to be amended?
I genuinely thought it was a mistaken inclusion at first.
(test suite was the only thing that stopped me nuking it (: )