Ensure source map can be resolved from cached code #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the more commonly used extension for source map files. Fix the test which erroneously looked for `.js` files where it meant `.map`.
When loading the test file, test workers intercept the require call and load the cached code instead. Libraries like nyc may also be intercepting require calls, however they won't know that different code was loaded. They may then attempt to resolve a source map from the original file location. This commit adds a source map file comment to the cached code. The file path is relative from the directory of the original file to where the source map is cached. Add a test which mimics how nyc resolves the source map.
|
By analyzing the blame information on this pull request, we identified @spudly, @jokeyrhyme and @sotojuan to be potential reviewers |
|
LGTM |
sindresorhus
added a commit
that referenced
this pull request
Mar 22, 2016
…mments Ensure source map can be resolved from cached code
|
LGTM2 |
novemberborn
added a commit
that referenced
this pull request
Apr 5, 2016
The generateMapFileComment() method used in #662 isn't available in v1.1.2.
This was referenced Apr 5, 2016
Closed
sindresorhus
pushed a commit
that referenced
this pull request
Apr 5, 2016
* convert-source-map@^1.2.0 The generateMapFileComment() method used in #662 isn't available in v1.1.2. * use already required convert-source-map dependency No need to require the generateMapFileComment() method separately. Also remove unnecessary linebreak at the end of the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In kentcdodds/react-ava-workshop#5 nyc is instrumenting the test files. Due to how our caching precompiler works nyc doesn't realize it's instrumenting the transpiled code. It can't find a source map for the transpiled code causing it to crash when generating coverage reports.
Generating coverage reports for test files shouldn't be necessary (and nyc excludes them by default), but it's not something that should crash either.
This PR adds a source map file comment to the cached code. The path is relative to that of the original file, allowing nyc to resolve the source map.
It also changes the source map file extension to the more conventional
.js.map.I think this is a better fix than #655 since we don't have to include the source map in an inline comment. The solution might be too specific to nyc though I imagine other module-loading-intercepting-libraries would behave the same way.