-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making the Whole Project/Repo Menu-Driven #831
Comments
Can I work on this issue under GSSOC21? Kindly assign it to me. |
I've a suggestion. We can start by categorizing each script into a dictionary.. something like: We can also make a function to act as an API which adds a new script with the suitable tags, and help contributors to automate the process of adding their scripts to this script instead of manually adding them. (Let's leave that for after we settle on how we will save the data of the existing scripts.) |
Hey..! What if we create a script that takes folder names as arguments and lets the user decide which folder thier script is to be moved in to and also an option to add a newer category. |
Hi, @Ajay-Singh-Rana @XZANATOL @AshuKV, As I have just returned home, I need some time to plan out the overall structure of the script, how it will handle new scripts and how we can have a GUI for that. I will update you on this day after tomorrow |
Any updates..? |
Will update by EOD |
Hey @kaustubhgupta If Need any help or any doubt kindly text me on discord..Participants are asking about this Issue.. |
Hi, @AshuKV @XZANATOL @avinashkranjan @Ajay-Singh-Rana (Apologies for updating late, was busy with important work), I liked the @XZANATOL implementation to create the database of scripts based on categories. I think a big JSON would do the work. Why JSON? Because it can be loaded into the dictionary in Python. Creating this JSON would be a manual task initially as we can't trace back to every merged pull request and check if it was a scrapper or ML script as neither the participants have filled the PR template properly nor there was an option to add a category. @Ajay-Singh-Rana Your idea has a problem that a new user would not be aware of the folder where the script lies. Also, one major problem apart from these ideas is that all participants have different entry points for their script. Some of them have main.py, scrapper.py, or script-specific names. Here is my workaround for this issue in 4 tasks (Please read till the end before assuming why I am asking these):
As these tasks are themselves way too big, every task will be rewarded
Let me know what should be modified, any new ideas except this, or anything else. Also, which task you are interested in. VERY IMPORTANT INFO: THIS WHOLE ISSUE IS NOT I have created a separate discussion thread for this. Join here: #882 |
Hey...Why not make things easy by moving scripts to specific task categories in the repo itself..?This would also make the repository much more accessible based on specificity. |
@Ajay-Singh-Rana many scripts can belong to many different categories, not only one.. so doing this will make it even harder to keep track of the scripts when we try to display them according to specificity 🤔 |
We are not aiming to restructure the repo but create a master script to initiate any script of this repo |
Finally got free from my commitments.. xd |
@XZANATOL Cool, you can start working on this sub-task. |
@kaustubhgupta @XZANATOL do you guys mean that the repository would remain as it is and the JSON has to be manually created at first and lateron we can give an option to add the script under a particular section by passing the arguments..? Is it..? |
@kaustubhgupta Hi there, I've finsihed most of the JSON file, here is a small part of how it is structured. The JSON file follows this structure: |
Perfect, 💯 I am working on the Pull request automation locally and maybe I will create the pull request for that. Let's see how this works and then we can move towards making the demo script! |
Yes @Ajay-Singh-Rana. If you want, you can work on the pull request automation. |
@kaustubhgupta I would like to work the 2nd task - Creating the demo Script for testing |
Hi @Ayushjain2205, Let @XZANATOL update the database and then I can explain you better about actual implementation |
@kaustubhgupta I've a doubt, There are some scripts that needs a |
@kaustubhgupta ok the PR is ready, double check my changes and update me if I'm missing something. For the added projects.. These are the projects that haven't been added till now, becuase of the issues mention in this comment
These are the projects which I've updated in the PR.
I've a doubt. How are we going to add these projects which are still at hold? or is there more manual work awaiting me? xD |
BTW, We need to make another PR for so we need to push the DB first. I'm going to wait your review about the currently openned PR and if it is good to go then I'll make one for |
Haha, nope, that's where I will assign @devRawnie the task of checking the scripts for adding/modifying the requirements.txt file for all the scripts. I will add copy-paste this comment in that issue.
|
Oh that's not what I meant. the action will update the file on both branches but the thing is on the first run of the action. currently on the PR merge the DB will exist on the main branch only not |
Oh, my bad. Let me add the database manually on that branch, |
I have added the file |
@kaustubhgupta So for now, after the user selects a particular script, the description will he shown to him and the packages will be installed from requirements.txt file. Based on the description. The user would enter command line arguments if required and finally the script will run taking in those arguments, fron the user. Tell me if I am missing something. I will be finalizing this by tonight. |
Correct, this is the flow for this script |
@kaustubhgupta I have completed the PR for the main.py script. It is throwing errors for some scripts because of the issue we discussed regarding the requirements.txt file. Kindly check |
okay I will check |
@kaustubhgupta I think there is something wrong with Personal Access Token -PAT- in the repo.. is it updated? There are 2 logs in the action tab where the script ran successfully till the part where it logins using the PAT. There is another log that failed which was weird a bit, but looking a bit closely.. the contributor changed a letter in a line which prevented the Regex detection and threw an error. Looking at the PR body.. turns out he changed the begging of the line of the requirments path from |
The PR token thing is conveyed to the PA and we will create a new token for this. Regarding the PR body thing, well it was a mistake from your side and mine too. The spelling of requirements was wrong and the same was updated in the PR. I had to fix that in the template and the code. Also, as the action failed for 3 PRs, I had to add that data manually. 🤣🤣 |
@XZANATOL Also, try to run this PR locally: #1030 How the database is useful for website too! Great work done by @Ayushjain2205 |
can't believe that slipt down of our eyes 😂 |
Yes, you can clone it locally and open the live server. The search for contributors and scripts is done using this json |
It should load the scripts. Maybe do a hard refresh (pressing cntrl while pressing refresh button) |
Tried it, and no results |
It works, check out the deployed website: https://avinashkranjan.github.io/Amazing-Python-Scripts/ |
which folder is responsible for the actual website i.e., the folder which consisi for homepage, contactpage, scriptspage |
Switch to branch |
there is no branch named gh-pages Because my issue is regarding improving the Contact-Us page of the website, so where can i find the code for that page? |
https://github.com/avinashkranjan/Amazing-Python-Scripts/tree/gh-pages You can check this out |
[UPDATE]: Check this comment for progress on this issue: #831 (comment)
Is your feature request related to a problem? Please describe.
Changing directories looking for scripts to use one by one will be quite a headache.
Describe the solution you'd like
Making it a menu-driven script, where a user can select the option and the specific script will run (can take arguments too if needed at runtime) in sort like
Lazy Script
if you are aware of.Let me brief you about what you have to do on this issue:
Which can be done in the following ways
and More
ie. /root/your_filename
while working on githubMarking Guidelines
Level3
, Each Linked PR would be of MinimumLevel2
.@kaustubhgupta @antrikshmisri @santushtisharma10 Kindly Helpout the Contributors working on this particular Issue..As this one is a complex issue..If Any Issues, DM me on Discord..
Happy Coding..👨🏻💻
The text was updated successfully, but these errors were encountered: