Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Scripts contributors on Website with implementation of search bar #1030

Merged
merged 7 commits into from
May 18, 2021

Conversation

Ayushjain2205
Copy link
Contributor

Description

Updating Scripts contributors on Website with implementation of search bar

Fixes #1013

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines(Clean Code) of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have created a helpful and easy to understand README.md
  • My documentation follows Template for README.md

@Ayushjain2205
Copy link
Contributor Author

@kaustubhgupta I had to create a new PR for the issue as the old PR was on a conflicting branch and I was not able to make the changes there.
Should I close the previous PR?

@kaustubhgupta
Copy link
Contributor

@kaustubhgupta I had to create a new PR for the issue as the old PR was on a conflicting branch and I was not able to make the changes there.
Should I close the previous PR?

Okay no issues, I have closed that PR

Copy link
Contributor

@kaustubhgupta kaustubhgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some issues:

  • Contact us page has no back button. Add a back button to return to the home page.
  • For some reason, the scripts searching is not working. I think in the earlier PR, you only added the script,js but in this PR, the old scripts.html is conflicting.
    image
  • The home button in scripts.html points to home.html which does not exist. Kindly point it to the index.html

Other changes:

index.html Outdated Show resolved Hide resolved
@kaustubhgupta kaustubhgupta added the bug Something isn't working label May 11, 2021
@Ayushjain2205
Copy link
Contributor Author

@kaustubhgupta Changes made please take a look at it

Added lastest changes
Copy link
Contributor

@kaustubhgupta kaustubhgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job @Ayushjain2205 💯 💯

I have updated the database with changes that we made today

@kaustubhgupta kaustubhgupta added next review needed Approved by some mentors, more approvals needed Urgent Issues needed to be address Immediately and removed bug Something isn't working labels May 11, 2021
@kaustubhgupta kaustubhgupta added Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level3 New features, Major bug fixing and removed next review needed Approved by some mentors, more approvals needed labels May 12, 2021
@kaustubhgupta kaustubhgupta merged commit 79ed300 into avinashkranjan:gh-pages May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved PR Approved and Ready to Merge gssoc23 Issues created for/by the GirlScript Summer of Code'23 Participants level3 New features, Major bug fixing Urgent Issues needed to be address Immediately
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updating Scripts contributors in Website, implementation of search bar and releasing the first draft!
4 participants