-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Scripts contributors on Website with implementation of search bar #1030
Updating Scripts contributors on Website with implementation of search bar #1030
Conversation
@kaustubhgupta I had to create a new PR for the issue as the old PR was on a conflicting branch and I was not able to make the changes there. |
Okay no issues, I have closed that PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some issues:
- Contact us page has no back button. Add a back button to return to the home page.
- For some reason, the scripts searching is not working. I think in the earlier PR, you only added the script,js but in this PR, the old scripts.html is conflicting.
- The home button in scripts.html points to home.html which does not exist. Kindly point it to the index.html
Other changes:
@kaustubhgupta Changes made please take a look at it |
Added lastest changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Job @Ayushjain2205 💯 💯
I have updated the database with changes that we made today
Description
Updating Scripts contributors on Website with implementation of search bar
Fixes #1013
Type of change
Checklist:
README.md
Template for README.md