Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter by location for default cards in custom dashboard #1185

Closed
Tracked by #1194
mahalakshme opened this issue Nov 13, 2023 · 3 comments
Closed
Tracked by #1194

Filter by location for default cards in custom dashboard #1185

mahalakshme opened this issue Nov 13, 2023 · 3 comments
Assignees

Comments

@mahalakshme
Copy link
Contributor

mahalakshme commented Nov 13, 2023

Motivation:

  • As a user, when default cards (ScheduledVisits, OverdueVisits, Last 24 hour registerations, Last 24 hour enrolments, Last 24 hours visits, Total and DueChecklist) of standard report card type are added to the custom dashboard, I am unable to filter the result.
  • And adding these filters will take us closer to deprecating MyDashboard and replacing it with CustomDashboards.

Analysis:

  • What is default card? Standard report cards that display on MyDashboard. Note: We dont display all standard report cards on MyDashboard.
  • Currently, filters for default cards in MyDashboard already support filtering by address. The logic for adding locationQuery is in MyDashboardActions.js

Acceptance criteria:

  • Should support filtering at all locations levels in the hierarchy for all the default cards.
  • Existing filters of Mydashboard should continue to work as before.
  • Performance should be within reasonable level. Test the same with prod data.
  • MyDashboard will eventually be deprecated. Keep that in mind, when deciding to take on any big refactorings.

Known Issues to be fixed in this card:

  • Fix issue with first time login for Power user nupoork@power on staging / local

Tech tasks

  • We have been working on this using Power org

  • We have made use of OR filter on locationAddressLevel UUID to do the reduction

  • Wherever the impacted methods are also invoked by MyDashboard, we send empty arrayList to make it a no filter operation

  • Has to be done for all standard ReportCards
    - case standardReportCardType.isDefaultType() :
    - case standardReportCardType.isChecklistType() :

  • Has to be done for all subTypes within each of the above standard report cards

  • Tests have to be created for each of the standardReportCardType and their subtypes

@mahalakshme mahalakshme converted this from a draft issue Nov 13, 2023
@mahalakshme mahalakshme moved this from In Analysis to Ready in Avni Product Nov 13, 2023
@mahalakshme mahalakshme changed the title Filter by location for default cards Filter by location for default cards in custom dashboard Nov 13, 2023
@mahalakshme mahalakshme moved this from Ready to Finalized for the upcoming release in Avni Product Nov 13, 2023
@mahalakshme mahalakshme moved this from Finalized for the upcoming release to Ready in Avni Product Nov 13, 2023
@petmongrels petmongrels moved this from Ready to In Progress in Avni Product Nov 13, 2023
@petmongrels petmongrels self-assigned this Nov 13, 2023
petmongrels added a commit that referenced this issue Nov 16, 2023
… the contract objects (without rule in them). approval cards filtered based on locations.
@himeshr himeshr moved this from In Progress to Hold in Avni Product Nov 22, 2023
@mahalakshme
Copy link
Contributor Author

@himeshr @petmongrels there are other cards to take care of approval, comment, task and checklist. this card deals with only default type. I ve mentioned in the description. This is to parallelise work once this card is done and to not block the release and to group by complexity.

@mahalakshme mahalakshme moved this from Hold to Ready in Avni Product Nov 29, 2023
@himeshr himeshr moved this from Ready to In Progress in Avni Product Nov 29, 2023
himeshr added a commit that referenced this issue Nov 29, 2023
himeshr added a commit that referenced this issue Nov 29, 2023
himeshr added a commit that referenced this issue Nov 29, 2023
himeshr added a commit that referenced this issue Nov 29, 2023
himeshr added a commit that referenced this issue Nov 29, 2023
@himeshr
Copy link
Contributor

himeshr commented Nov 29, 2023

Code changes done and test created to support filter by location for following:
(ScheduledVisits, OverdueVisits, Last 24 hour registerations, Last 24 hour enrolments, Last 24 hours visits, Total and DueChecklist)

Pending work:
Fix issue with first time login for Power user nupoork@power on staging / local

@himeshr himeshr moved this from In Progress to Code Review Ready in Avni Product Nov 30, 2023
@himeshr
Copy link
Contributor

himeshr commented Nov 30, 2023

Unable to reproduce the first time login failure for Power user nupoork@power on local.
There were minor regression issues fixed as part of earlier commits, which might have resolved this.
Moving to CodeReviewReady.

@vinayvenu vinayvenu moved this from Code Review Ready to In Code Review in Avni Product Dec 1, 2023
@vinayvenu vinayvenu moved this from In Code Review to Code Review Ready in Avni Product Dec 1, 2023
@1t5j0y 1t5j0y moved this from Code Review Ready to In Code Review in Avni Product Dec 11, 2023
@1t5j0y 1t5j0y moved this from In Code Review to QA Ready in Avni Product Dec 11, 2023
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Dec 12, 2023
@AchalaBelokar AchalaBelokar moved this from In QA to Done in Avni Product Dec 12, 2023
1t5j0y added a commit that referenced this issue Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants