Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter by location for Comment and Task standard report cards #1186

Closed
Tracked by #1194
mahalakshme opened this issue Nov 13, 2023 · 6 comments
Closed
Tracked by #1194

Filter by location for Comment and Task standard report cards #1186

mahalakshme opened this issue Nov 13, 2023 · 6 comments
Assignees

Comments

@mahalakshme
Copy link
Contributor

mahalakshme commented Nov 13, 2023

Motivation:

Being able to filter will complement with the filters applied to other standard report cards

Acceptance criteria:

  • Comments and tasks should be filtered by the subjects location
  • Should work with all task type cards - Tasks, Call tasks and Open Subject tasks
  • If subject is not present for a task/comment entry, when filtered by location that entry should not appear in filter results.
  • Should work with filtering at all address levels
  • Performance should be within reasonable level. Test the same with prod data.
  • MyDashboard will eventually be deprecated. Keep that in mind, when deciding to take on any big refactorings related to it.

Dependency:

@mahalakshme mahalakshme converted this from a draft issue Nov 13, 2023
@mahalakshme mahalakshme moved this from In Analysis to Ready in Avni Product Nov 15, 2023
@1t5j0y 1t5j0y moved this from Ready to In Progress in Avni Product Dec 8, 2023
@1t5j0y 1t5j0y self-assigned this Dec 8, 2023
@1t5j0y 1t5j0y moved this from In Progress to Ready in Avni Product Dec 8, 2023
@1t5j0y 1t5j0y removed their assignment Dec 8, 2023
@petmongrels petmongrels moved this from Ready to In Progress in Avni Product Dec 19, 2023
@petmongrels petmongrels self-assigned this Dec 19, 2023
@petmongrels petmongrels moved this from In Progress to Code Review Ready in Avni Product Dec 20, 2023
@petmongrels
Copy link
Contributor

these two commits as well

@1t5j0y 1t5j0y moved this from Code Review Ready to In Code Review in Avni Product Dec 26, 2023
@1t5j0y 1t5j0y moved this from In Code Review to QA Ready in Avni Product Dec 26, 2023
@Dinesh2019
Copy link

Dinesh2019 commented Jan 3, 2024

we still able to see the filter is not applying for standard card attached the video for the reference.
Use master branch latest commit as of 03 Jan 2024, Staging APK for testing.
APK Link: https://app.circleci.com/pipelines/github/avniproject/avni-client/2206/workflows/09629395-3431-4aa8-b8cb-150c70db9869/jobs/13621/artifacts

Screen.Recording.2024-01-03.at.11.43.42.AM.mov

@Dinesh2019 Dinesh2019 moved this from QA Ready to QA Failed in Avni Product Jan 3, 2024
@petmongrels petmongrels moved this from QA Failed to In Progress in Avni Product Jan 8, 2024
@petmongrels
Copy link
Contributor

This is not a bug, tested with actual address filter (which is saved now)
The dashboard filter is misleading and this implementation is good for testing this.

  • the dashboaord filter says location but is pointing to concept
  • the registration for also doesnt work in this impl because the saving the observation in the form for "location" not address doesnt save the data.

@petmongrels petmongrels moved this from In Progress to QA Ready in Avni Product Jan 8, 2024
@Dinesh2019 Dinesh2019 moved this from QA Ready to In QA in Avni Product Jan 9, 2024
@Dinesh2019 Dinesh2019 moved this from In QA to Done in Avni Product Jan 9, 2024
@Dinesh2019
Copy link

Dinesh2019 commented Jan 10, 2024

@petmongrels Issue happens in pre-release

org: power

Steps to reproduce:
1.Login in the app
2.enabled the comment in the org
3.added the card and added the filter in the offline dashboard
4.add the applying the filter count becomes zero

Screen.Recording.2024-01-10.at.2.03.53.PM.mov

@Dinesh2019 Dinesh2019 moved this from Done to QA Failed in Avni Product Jan 10, 2024
@mahalakshme
Copy link
Contributor Author

@petmongrels looks like a bug found on a 6.1.0 card

@vinayvenu vinayvenu reopened this Jan 10, 2024
@github-project-automation github-project-automation bot moved this from QA Failed to Triaged in Avni Product Jan 10, 2024
@mahalakshme mahalakshme moved this from Triaged to QA Failed in Avni Product Jan 11, 2024
@petmongrels petmongrels moved this from QA Failed to In Progress in Avni Product Jan 11, 2024
petmongrels added a commit to avniproject/avni-models that referenced this issue Jan 11, 2024
petmongrels added a commit that referenced this issue Jan 11, 2024
#1186 - english text
@petmongrels
Copy link
Contributor

The subject is registered to Test01->Test01 that is why it is not showing when only Test01 is selected. This is how the feature has been implemented. I have added a subtext to clarify this.

@petmongrels petmongrels moved this from In Progress to Code Review Ready in Avni Product Jan 11, 2024
petmongrels added a commit to avniproject/avni-models that referenced this issue Jan 11, 2024
petmongrels added a commit that referenced this issue Jan 11, 2024
…and date. ProgramEnrolmentsView not getting used anywhere. model version with audit sync changes.
@vinayvenu vinayvenu moved this from Code Review Ready to In Code Review in Avni Product Jan 12, 2024
petmongrels added a commit that referenced this issue Jan 12, 2024
@vinayvenu vinayvenu moved this from In Code Review to QA Ready in Avni Product Jan 12, 2024
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Jan 15, 2024
@AchalaBelokar AchalaBelokar moved this from In QA to Done in Avni Product Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

5 participants