Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Being able to apply subject type filter on Due and overdue visits cards when part of custom dashboard #1381

Closed
Tracked by #912 ...
mahalakshme opened this issue Apr 16, 2024 · 3 comments
Assignees

Comments

@mahalakshme
Copy link
Contributor

mahalakshme commented Apr 16, 2024

Need:

  1. Frequently we are unable to use SRC as such because users want to customise it based on program or encounter.
    Eg:
  • Overdue visits for child followup in APF Odisha - which is based on program, encounter type
  • No of Follow-up visits due for Epilepsy followup in JSSCP - Infividual ST, followup encounter type, Epilepsy program
  • Due WIMC meeting in AKRSP - WIMC meeting encounter type and Individual subject type
  • Eye checkup due in Chashma - 'Eye checkup' encounter type and Patients subject type
  1. To be able to achieve MyDashboard functionalities via Custom Dashboard code ie. to have the code at one place eventually.

Example configurations:

--- 1. I add a 'Scheduled Visits' report card to a custom dashboard, with subject type as Child(configured on report card). This is needed when a user wants to see due visits for all subject types in primary dashboard, without having to filter each time.
--- 2. I have 'Scheduled Visits' report card added to custom dashboard without any filters configured on report card, but 'Subject type' configured on custom dashboard filters. This is useful for cases where user would like to decide on the filters when using the app.

Acceptance criteria:

  • When the 2nd configuration mentioned here is done, then, in mobile app, subject type filter need to work similar to the default subject type filter in MyDashboard:
    - Based on the subject type selected - general encounter types and program need to show
    - Based on the program selected, program encounter types need to show up
  • When the 1st configuration, mentioned here is done, the above is not applicable since the program and encounter type filters are already configured in 'App Designer'.
    - The card color needs to be of the configured color. Currently for standard report cards we have hardcoded the colors.
  • For both configurations, applied filters need to work on Due and Overdue cards in SRC added to CD.
  • The expectation is both configurations will not be used at the same time.

Additionally impacted Areas

  • Custom Dashboard Filters cache across Landing Page and Dashboards page
  • In-general the CustomDashboard functionality and Filter capabilities
  • CustomReportCards standard and non-standard with Filters removed and applied both

Technical details:

Have added the ACs for both configurations in the same card, since its good to have the same code for applying filters for both configurations.

@mahalakshme mahalakshme transferred this issue from avniproject/avni-webapp Apr 19, 2024
@mahalakshme mahalakshme changed the title Add ability to parametrize SRC in CD Being able to apply subject type filter for Due and overdue visits cards when part of custom dashboard Apr 19, 2024
@mahalakshme mahalakshme changed the title Being able to apply subject type filter for Due and overdue visits cards when part of custom dashboard Being able to apply subject type filter on Due and overdue visits cards when part of custom dashboard Apr 19, 2024
@mahalakshme mahalakshme moved this from In Analysis to In Analysis Review in Avni Product Apr 19, 2024
@mahalakshme mahalakshme moved this from In Analysis Review to Analysis Complete in Avni Product May 10, 2024
@mahalakshme mahalakshme moved this from Analysis Complete to Ready in Avni Product May 22, 2024
@petmongrels petmongrels moved this from Ready to In Progress in Avni Product May 23, 2024
@petmongrels petmongrels self-assigned this May 23, 2024
@petmongrels
Copy link
Contributor

petmongrels commented May 23, 2024

Notes

  • marked as high risk due to refactoring being done. DashboardFilterCache was storing extra variables that could be computed.
  • all custom dashboard caches will be invalidated

petmongrels added a commit to avniproject/avni-server that referenced this issue May 27, 2024
petmongrels added a commit to avniproject/avni-models that referenced this issue May 30, 2024
… from the CustomDashboardCache. deserialise input form meta data params to the report card. delete all existing dashboard cache.
petmongrels added a commit that referenced this issue May 30, 2024
…icates, unusable or can be derived. moved serialisaton and deserialisation code to service.
petmongrels added a commit that referenced this issue May 31, 2024
…ounter type service to provide all entities with privilege for given parent entities. multi-selectable subject type, encounter type and program UI component.
petmongrels added a commit that referenced this issue May 31, 2024
petmongrels added a commit to avniproject/avni-webapp that referenced this issue May 31, 2024
… no items. in report card listing display standard report card type name.
petmongrels added a commit to avniproject/avni-server that referenced this issue May 31, 2024
@petmongrels petmongrels moved this from In Progress to Code Review Ready in Avni Product May 31, 2024
@himeshr himeshr moved this from Code Review Ready to In Code Review in Avni Product Jun 10, 2024
himeshr added a commit to avniproject/avni-server that referenced this issue Jun 10, 2024
…sponse for all ReportCardController web endpoints
@himeshr himeshr moved this from In Code Review to QA Ready in Avni Product Jun 10, 2024
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Jul 1, 2024
@AchalaBelokar AchalaBelokar moved this from In QA to QA Ready in Avni Product Jul 1, 2024
@AchalaBelokar AchalaBelokar moved this from QA Ready to In QA in Avni Product Jul 31, 2024
@AchalaBelokar AchalaBelokar moved this from In QA to QA Ready in Avni Product Jul 31, 2024
@mahalakshme
Copy link
Contributor Author

mahalakshme commented Sep 10, 2024

@petmongrels
Subject type filters are working very differently between the default custom dashboard and MyDashboard

  • In the new default custom dashboard, general encounter types continue to display even after program is selected - which leads to confusion regarding say the no on Overdue visits card
  • In the bar on top that displays the applied filters, Program and Encounter type filters displays with | separation instead of showing labels Program, Encounter Type

https://drive.google.com/file/d/1HMH25q-2WQQsPgX_S9iB4jy9jxvK1MWQ/view?usp=drive_link - screenshot link

@mahalakshme mahalakshme moved this from In QA to QA Failed in Avni Product Sep 10, 2024
petmongrels added a commit that referenced this issue Sep 12, 2024
…pplied filters. selection of program will stop showing general encounter types.
@petmongrels petmongrels moved this from In Progress to QA Ready in Avni Product Sep 12, 2024
@himeshr himeshr moved this from QA Ready to In QA in Avni Product Sep 18, 2024
@himeshr
Copy link
Contributor

himeshr commented Sep 18, 2024

Test cases

  • Sanity of Custom Dashboards { create / edit dashboard, create / edit sections, create/edit filters, create/edit reportCards}
  • Creation of SubjectType filter on dashboard
  • Creation of AsOnDate filter on dashboard
  • Creation of Standard report card with SubjectType, Program and EncType filters config
  • Creation of Custom Query report card to use Dashboard SubjectType filter
  • Primary / Secondary dashboards
  • Caching dahboard filters
  • Ensure that Config clash of dashboard filter and reportCard config is handled correctly and zero results are returned there

@himeshr himeshr closed this as completed Sep 18, 2024
@github-project-automation github-project-automation bot moved this from In QA to Done in Avni Product Sep 18, 2024
@vinayvenu vinayvenu reopened this Sep 19, 2024
@github-project-automation github-project-automation bot moved this from In QA to Triaged in Avni Product Sep 19, 2024
@mahalakshme mahalakshme moved this from QA Ready to Done in Avni Product Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

5 participants