Being able to apply all custom filters on Due and Overdue visits cards added to custom dashboard #1382

mahalakshme · 2024-04-19T12:01:46Z

Need:

When specific filters for subject type like mentioned here it needs to work in mobile app
Example usecase: To support 'Weight for Age grade' in JSSCP that is configured currently in MyDashboard for a specific subject type.
When the same filter types(Gender, Registeration Date, Enrolment Date, Encounter Date, Program Encounter Date, Address, Concept, Group Subject) are configured generically without being under 'Subject Type' filter as well it need to work
Example usecase: To support filtering by a concept present in registeration forms of all subject types

As is:

Currently only Location filter is supported on Due and Overdue visits card when configured generically(without being based on subject type)

AC:

All the above mentioned filters when configured(with or without being specific to subject type) need to work when 'Due/Scheduled visits' and 'Overdue visits' card added to custom dashboard.

Technical details:

Made applying of filters with and w/o subject type as part of same card, since its good to have the same code for both cases and the subject type filter will only get applied additionally in the 1st case.

himeshr · 2024-06-06T11:40:52Z

Code review and QA is pending for below specified cards, only after which we should resume further deveopment here as all changes in these cards have been throwing up errors or blocking dev org configuration.

avniproject/avni-webapp#1203
avniproject/avni-webapp#1204
avniproject/avni-webapp#1235
#1381

petmongrels · 2024-06-13T05:51:44Z

Card dev notes

check if filter cache is working when there are more than one gender filter values (done)
removing subject types should remove the program/encounter types as well (done)
test with multiple address levels on user's device (done)
throw error to check whether cache is getting reset (done)

Design doc topics

How checksum is maintained
How and why handle errors during filtering
Responsibility definition

QA notes

Regression required for MyDashboard (especially address levels)
Since concept has multiple data types, testing should be done for this card for different data types
Please also check whether each type of filters are getting remembered
Also check any implementation that have used Custom Report cards based on rules recently, to check if they are working fine too.

…en unselected in the filters. fixed BaseService find by all uuid. refactored custom filter service so that it can be reused. removed wrong use of state at the service level for individuals. used CustomFilterService in scheduled report card type.

…ashboaerd cache to have empty objects hash value.

…es. Intialise filters with nullobjects when there is no previous value for them.

…es specific value types to identify whether value is present or not. Support date range based on Range value type. Separate V1 and V2 code in some other places. from dev settings also clear custom dashboard cache. hash based on filter configs JSON using jshashes library. logger to allow multiple arguments like console log. removed unused functional methods from General and move logging related method be internal to General.

…nfig. custom dashboard cache can be instantiated and reset with hash as the filters are known at the time. fixed bugs in MetaDataService.

…lay text methods for console logging. v2 function for concept filter query due to difference in data representation.

…cted address list.

mahalakshme · 2024-06-21T06:32:48Z

@petmongrels getting this error after configuring the below dashboard. Seems to be getting after deleting the dashboard as well

AchalaBelokar · 2024-08-29T11:39:17Z

Env: prereleases

Login with maha@apfodisha and created a card household with group subject type filter . but filter is not working.

az_recorder_20240829_170046.mp4

petmongrels · 2024-08-30T06:07:44Z

fixed. the second report card will show the correct numbers now.
FYI - Please note that the first report card will show zero because it is showing number of households which is part of group household. not a valid condition.

AchalaBelokar · 2024-08-30T08:44:43Z

I login with maha@apfodisha and go to the household dashboard and added the location filter but it is not showing the value it is giving me error
Cannot set property 'isSelected' of undefined
at anonymous (address at index.android.bundle:1:2417179)
at forEach ((native)::)
at setSelectedAddresses (address at index.android.bundle:1:2417114)
at anonymous (address at index.android.bundle:1:4248687)
at anonymous (address at index.android.bundle:1:1112823)
at map ((native)::)
at apply ((native)::)
at value (address at index.android.bundle:1:2247068)
at map (address at index.android.bundle:1:1112785)
at render (address at index.android.bundle:1:4247660)
at finishClassComponent (address at index.android.bundle:1:367544)
at updateClassComponent (address at index.android.bundle:1:367405)
at beginWork$1 (address at index.android.bundle:1:399723)
at performUnitOfWork (address at index.android.bundle:1:386774)
at workLoopSync (address at index.android.bundle:1:386676)
at renderRootSync (address at index.android.bundle:1:386560)
at performSyncWorkOnRoot (address at index.android.bundle:1:384043)
at flushSyncCallbacks (address at index.android.bundle:1:349073)
at batchedUpdatesImpl (address at index.android.bundle:1:400497)
at batchedUpdates (address at index.android.bundle:1:341930)
at _receiveRootNodeIDEvent (address at index.android.bundle:1:342203)
at receiveTouches (address at index.android.bundle:1:395353)
at apply ((native)::)
at __callFunction (address at index.android.bundle:1:98035)
at anonymous (address at index.android.bundle:1:96528)
at __guard (address at index.android.bundle:1:97468)
at callFunctionReturnFlushedQueue (address at index.android.bundle:1:96486)

az_recorder_20240830_140907.mp4

petmongrels · 2024-09-09T09:58:54Z

moving it to QA, as the prerelease environment has been refreshed

AchalaBelokar · 2024-09-13T08:41:56Z

[ ]I created the new card named household and the card is not displayed in the mobile app
https://drive.google.com/file/d/1PNGGJmm_GqsTRhmq0Iow1WeoHOqFL5FG/view?usp=sharing

himeshr · 2024-09-18T13:22:22Z

Details

Env: prerelease
Org: apf
User: dineshg

Related links:
https://prerelease.avniproject.org/#/appDesigner/dashboard/616/show

Issue description

Program Encounter date filters seem to be incorrectly applied for Overdue visits as seen in following screen-recording

https://drive.google.com/file/d/1FJQ2YiOCwpZN5ZUeDg6cRz371v2k9c-_/view?usp=sharing

himeshr · 2024-09-18T13:36:22Z

Details

Env: prerelease Org: apf User: dineshg

Related links: https://prerelease.avniproject.org/#/appDesigner/dashboard/616/show

Issue description

Program Encounter date filters seem to be incorrectly applied for Overdue visits as seen in following screen-recording

https://drive.google.com/file/d/1FJQ2YiOCwpZN5ZUeDg6cRz371v2k9c-_/view?usp=sharing

Based on discussions with Maha, this seems to be current behaviour on mydashboard, where-in the progEncDate filter is applied on all encounters of individual and then we search for individuals with due visits amongst them.. Instead of searching for dueVisits with scheduledDate for the ProgEncDate filter value.

himeshr · 2024-09-18T13:39:05Z

THIS HAS TO BE FIXED

MyDashboard filter by registrationDate is broken.. Continue testing with Prod old apk to confirm that this was already the case earlier.

Comparision btwn APP versions 10.0 and 9.4 shows difference in results for the same user and org..

himeshr · 2024-09-19T08:58:01Z

THIS IS NOT TO BE FIXED

Issues found with new(10.0) and old (9.4) version of Avni APK MyDashboard are as follows:

MyDashboard, Individual Registration Date filter with value causes issues on relaunch of Avni app, Count of Due and Overdue visits cards are wrong
MyDashboard, ProgEncounterType filter values are not set correctly on Filters Screen, though they show up in applied filters section

https://drive.google.com/file/d/1Oif2BInTycQVx-xEGGYM9rwdcsOfyBGs/view?usp=sharing

petmongrels · 2024-09-20T12:09:49Z

not fixed another issue noticed

registration date range filter applied
restart app
filter is shown as applied but the counts are not calculated as per the filter

Same issues exists in 9.4 app

himeshr · 2024-09-23T06:23:29Z

MyDashboard filter by registrationDate is now fixed.. Did not find any new issues that were not present in older apk versions.

mahalakshme added this to Avni Product Apr 19, 2024

mahalakshme converted this from a draft issue Apr 19, 2024

This was referenced Apr 19, 2024

Implementation of dashboard filters on standard report cards #912

Closed

Being able to apply custom filters on standard report cards - Part 1 avniproject/avni-product#1581

Closed

mahalakshme changed the title ~~Being able to apply all custom filters on Due and Overdue visits cards~~ Being able to apply all custom filters on Due and Overdue visits cards added to custom dashboard Apr 19, 2024

mahalakshme moved this from In Analysis to In Analysis Review in Avni Product Apr 19, 2024

mahalakshme moved this from In Analysis Review to Analysis Complete in Avni Product May 10, 2024

mahalakshme moved this from Analysis Complete to Ready in Avni Product May 31, 2024

himeshr moved this from Ready to In Progress in Avni Product Jun 4, 2024

himeshr self-assigned this Jun 4, 2024

himeshr moved this from In Progress to Ready in Avni Product Jun 5, 2024

himeshr moved this from Ready to In Progress in Avni Product Jun 6, 2024

himeshr moved this from In Progress to Hold in Avni Product Jun 6, 2024

mahalakshme moved this from Hold to Ready in Avni Product Jun 12, 2024

himeshr removed their assignment Jun 12, 2024

petmongrels moved this from Ready to In Progress in Avni Product Jun 12, 2024

petmongrels self-assigned this Jun 12, 2024

petmongrels added a commit to avniproject/avni-models that referenced this issue Jun 17, 2024

avniproject/avni-client#1382 - filters property in Dashboard.

531b23d

petmongrels added a commit to avniproject/avni-models that referenced this issue Jun 19, 2024

avniproject/avni-client#1382 - Range class to support ranges. Empty d…

3e4b353

…ashboaerd cache to have empty objects hash value.

petmongrels added a commit that referenced this issue Jun 19, 2024

#1382 - programmatically update AddressLevelState for selected addres…

0f5c9ac

…es. Intialise filters with nullobjects when there is no previous value for them.

petmongrels added a commit that referenced this issue Jun 20, 2024

#1382 - bug fixes introduced due to changes in previous commits. disp…

025d5e9

…lay text methods for console logging. v2 function for concept filter query due to difference in data representation.

petmongrels added a commit that referenced this issue Jun 20, 2024

#1382 - fixed logic of programmatically building selected and un-sele…

64fab83

…cted address list.

mahalakshme mentioned this issue Jun 21, 2024

Being able to apply all custom filters on 'Recent' type cards when part of custom dashboard #1437

Closed

petmongrels added a commit that referenced this issue Jun 24, 2024

#1382 - filters as string instead of array and string both

ad3bcab

AchalaBelokar moved this from In QA to QA Failed in Avni Product Aug 29, 2024

petmongrels moved this from QA Failed to In Progress in Avni Product Aug 30, 2024

petmongrels added a commit that referenced this issue Aug 30, 2024

#1382 - fix: use group subject uuid correctly in custom filter

ba71aa5

petmongrels moved this from In Progress to QA Ready in Avni Product Aug 30, 2024

petmongrels added a commit that referenced this issue Aug 30, 2024

#1382 - fix: use group subject uuid correctly in custom filter

49cc31d

AchalaBelokar moved this from In QA to QA Failed in Avni Product Sep 5, 2024

petmongrels moved this from In Progress to QA Ready in Avni Product Sep 9, 2024

AchalaBelokar moved this from In QA to QA Failed in Avni Product Sep 13, 2024

petmongrels moved this from In Progress to QA Ready in Avni Product Sep 16, 2024

himeshr moved this from In QA to QA Failed in Avni Product Sep 19, 2024

petmongrels added a commit that referenced this issue Sep 20, 2024

#1382 - fixed intersection logic

952a160

petmongrels moved this from In Progress to Code Review Ready in Avni Product Sep 20, 2024

mahalakshme mentioned this issue Sep 20, 2024

Registration date filter not working #1513

Open

1t5j0y moved this from In Code Review to QA Ready in Avni Product Sep 23, 2024

himeshr moved this from QA Ready to In QA in Avni Product Sep 23, 2024

himeshr closed this as completed Sep 23, 2024

github-project-automation bot moved this from In QA to Done in Avni Product Sep 23, 2024

This was referenced Oct 4, 2024

Dashboard issues of previous release - part 1 #1523

Closed

[Custom Default Dashboard] Filters should display only for the configured subject type #1530

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Being able to apply all custom filters on Due and Overdue visits cards added to custom dashboard #1382

Being able to apply all custom filters on Due and Overdue visits cards added to custom dashboard #1382

mahalakshme commented Apr 19, 2024 •

edited

Loading

himeshr commented Jun 6, 2024

petmongrels commented Jun 13, 2024 •

edited

Loading

mahalakshme commented Jun 21, 2024 •

edited

Loading

AchalaBelokar commented Aug 29, 2024

petmongrels commented Aug 30, 2024

AchalaBelokar commented Aug 30, 2024 •

edited

Loading

petmongrels commented Sep 9, 2024

AchalaBelokar commented Sep 13, 2024 •

edited

Loading

himeshr commented Sep 18, 2024

himeshr commented Sep 18, 2024

Details

Issue description

himeshr commented Sep 18, 2024 •

edited

Loading

himeshr commented Sep 19, 2024 •

edited by petmongrels

Loading

petmongrels commented Sep 20, 2024

himeshr commented Sep 23, 2024

Being able to apply all custom filters on Due and Overdue visits cards added to custom dashboard #1382

Being able to apply all custom filters on Due and Overdue visits cards added to custom dashboard #1382

Comments

mahalakshme commented Apr 19, 2024 • edited Loading

Need:

As is:

AC:

Technical details:

himeshr commented Jun 6, 2024

petmongrels commented Jun 13, 2024 • edited Loading

Card dev notes

Design doc topics

QA notes

mahalakshme commented Jun 21, 2024 • edited Loading

AchalaBelokar commented Aug 29, 2024

petmongrels commented Aug 30, 2024

AchalaBelokar commented Aug 30, 2024 • edited Loading

petmongrels commented Sep 9, 2024

AchalaBelokar commented Sep 13, 2024 • edited Loading

himeshr commented Sep 18, 2024

Details

Issue description

himeshr commented Sep 18, 2024

Details

Issue description

himeshr commented Sep 18, 2024 • edited Loading

THIS HAS TO BE FIXED

himeshr commented Sep 19, 2024 • edited by petmongrels Loading

THIS IS NOT TO BE FIXED

petmongrels commented Sep 20, 2024

not fixed another issue noticed

himeshr commented Sep 23, 2024

mahalakshme commented Apr 19, 2024 •

edited

Loading

petmongrels commented Jun 13, 2024 •

edited

Loading

mahalakshme commented Jun 21, 2024 •

edited

Loading

AchalaBelokar commented Aug 30, 2024 •

edited

Loading

AchalaBelokar commented Sep 13, 2024 •

edited

Loading

himeshr commented Sep 18, 2024 •

edited

Loading

himeshr commented Sep 19, 2024 •

edited by petmongrels

Loading