Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: strip data-controller attribute #3606

Merged
merged 7 commits into from
Jan 27, 2025

Conversation

adrianthedev
Copy link
Collaborator

Description

Fixes an issue where the panel data-controller attribute would have an extra empty space.

Before:

data-controller="resource-edit "

After

data-controller="resource-edit"

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Copy link

codeclimate bot commented Jan 23, 2025

Code Climate has analyzed commit 8a49996 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

@Paul-Bob Paul-Bob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good to merge after fixing the failing feature test

@Paul-Bob Paul-Bob merged commit b12b3f9 into main Jan 27, 2025
20 checks passed
@Paul-Bob Paul-Bob deleted the fix/strip-panel-controller-attribute branch January 27, 2025 11:54
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants