Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: strip data-controller attribute #3606

Merged
merged 7 commits into from
Jan 27, 2025
Merged

fix: strip data-controller attribute #3606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7b69092
fix: strip data-controller attribute
adrianthedev Jan 23, 2025
cadaa49
wip
adrianthedev Jan 25, 2025
674894e
Merge branch 'main' into fix/strip-panel-controller-attribute
Paul-Bob Jan 27, 2025
e9999af
keep data component if existent
Paul-Bob Jan 27, 2025
dd75f1d
Merge branch 'main' into fix/strip-panel-controller-attribute
Paul-Bob Jan 27, 2025
996a57d
date time spec
Paul-Bob Jan 27, 2025
8a49996
Merge branch 'fix/strip-panel-controller-attribute' of github.com:avo…
Paul-Bob Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/components/avo/panel_component.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,6 @@ def classes
private

def data_attributes
@data.merge({"panel-index": @index})
@data.merge(component: @data[:component] || self.class.to_s.underscore, "panel-index": @index)
end
end
2 changes: 1 addition & 1 deletion lib/avo/concerns/has_resource_stimulus_controllers.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def get_stimulus_controllers

controllers << self.class.stimulus_controllers

controllers.join " "
controllers.reject(&:blank?).join " "
end

def stimulus_data_attributes
Expand Down
2 changes: 2 additions & 0 deletions spec/system/avo/date_time_fields/date_time_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,7 @@

close_picker
save
wait_for_loaded

expect(show_field_value(id: :started_at)).to eq "January 02, 2000 17:17:17 UTC"
end
Expand Down Expand Up @@ -256,6 +257,7 @@

close_picker
save
wait_for_loaded

expect(show_field_value(id: :started_at)).to eq "January 02, 2000 17:17:17 UTC"
end
Expand Down
Loading