Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare code for development #11

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

javierav
Copy link
Collaborator

@javierav javierav commented Oct 15, 2024

This PR prepares the code for the planned developments:

  • Add rubocop with standard gem to ensure code consistency and style, also running it in the CI.
  • Add a Gemfile for development dependencies, a best practice.
  • Add the development gems' binstubs to the bin folder to avoid having to prefix commands with bundle exec.
  • Adds support for direnv, a utility that allows, among other things, to automatically add the bin folder to the PATH environment variable every time we enter the project directory, closely related to binstubs. This allows us to directly use the rake command in the console and actually execute bin/rake, which in turn is like writing bundle exec rake.
  • Adds an IRB console in bin/console with the preloaded library for testing in development.
  • Set the gem to require ruby ​​>= 3.0
  • Fix all rubocop warnings.
  • Cleanup gitignore file.

Copy link
Contributor

@adrianthedev adrianthedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!
A lot of improvements here!

There's one thing I'd like us to be a little bit loose on.
Let's use standard as it provides a lot of good defaults and prevents us and future commiters to do a lot of yak shaving and fiddle with the linting rules.

Thanks a lot @javierav

.editorconfig Outdated Show resolved Hide resolved
.rubocop.yml Show resolved Hide resolved
@javierav javierav force-pushed the prepare-development branch from 6ce275c to f41ea03 Compare October 16, 2024 08:55
@javierav
Copy link
Collaborator Author

@adrianthedev changes ready!

@javierav javierav requested a review from adrianthedev October 16, 2024 10:44
@adrianthedev adrianthedev merged commit f0f5af5 into avo-hq:main Oct 16, 2024
@javierav javierav deleted the prepare-development branch October 16, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants