Deprecate usage of positional arguments #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierav
force-pushed
the
feature/deprecate-base
branch
from
e5e3535 to
44452f5
Compare
|
@adrianthedev It's a bit strange, but the CI's are not running on the PRs, do you have to configure something? |
|
Maybe it's because the PR was created before we merged the CI jobs? |
|
@adrianthedev solved in #14! |
javierav
force-pushed
the
feature/deprecate-base
branch
3 times, most recently
from
19b05dd to
fc6c63f
Compare
javierav
force-pushed
the
feature/deprecate-base
branch
from
fc6c63f to
418d609
Compare
Closed
adrianthedev
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a deprecation warning when a positional argument is used. In draft until #11 is merged. After this, a new version of the gem should be released so that developers can prepare for the new changes.