Skip to content

use navmesh movement code #59

use navmesh movement code

use navmesh movement code #59

Triggered via pull request July 16, 2024 16:45
Status Failure
Total duration 1m 41s
Artifacts

build_pr.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 1 warning
Build: BossMod/AI/AIMove.cs#L20
Provide an overridable implementation of Dispose(bool) on 'AIMove' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
Build: BossMod/AI/AIMove.cs#L22
Non-constant fields should not be visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2211)
Build: BossMod/AI/AIMove.cs#L59
Modify 'AIMove.Dispose' so that it calls Dispose(true), then calls GC.SuppressFinalize on the current object instance ('this' or 'Me' in Visual Basic), and then returns (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
Build: BossMod/AI/AIMove.cs#L59
Change AIMove.Dispose() to call GC.SuppressFinalize(object). This will prevent derived types that introduce a finalizer from needing to re-implement 'IDisposable' to call it. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1816)
Build: BossMod/AI/AIMove.cs#L40
'AIMove' contains field '_rmiFlyHook' that is of IDisposable type 'Hook<RMIFlyDelegate>', but it is never disposed. Change the Dispose method on 'AIMove' to call Close or Dispose on this field. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2213)
Build: BossMod/AI/AIMove.cs#L31
Make field readonly (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0044)
Build: BossMod/AI/AIMove.cs#L32
Make field readonly (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0044)
Build: BossMod/AI/AIMove.cs#L36
Make field readonly (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0044)
Build: BossMod/AI/AIMove.cs#L40
Make field readonly (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/style-rules/ide0044)
Build: BossMod/AI/AIMove.cs#L20
Provide an overridable implementation of Dispose(bool) on 'AIMove' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
Build
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/setup-dotnet@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/