-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(storage): add integration tests for multi-bucket support #2900
Merged
phantumcode
merged 20 commits into
feature/storage_multi-bucket_support
from
phantum/storage-multibucket-integ_test
Sep 4, 2024
Merged
chore(storage): add integration tests for multi-bucket support #2900
phantumcode
merged 20 commits into
feature/storage_multi-bucket_support
from
phantum/storage-multibucket-integ_test
Sep 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 21, 2024
Base automatically changed from
phantum/storage-update-transfer-db
to
feature/storage_multi-bucket_support
August 27, 2024 17:13
6 tasks
mattcreaser
approved these changes
Aug 28, 2024
vincetran
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi-bucket support part 4
This the 4th and last part of a series of changes/pull request to support multi-bucket in the S3 Storage Plugin. The series of changes will be reviewed and merged into a feature branch and combined into a single pull request to be reviewed and merged into main branch.
For references:
part 1: #2895
part 2: #2896
part 3: #2899
Issue #, if available:
Description of changes:
AWSS3StoragePlugin
that gets theAWSS3StorageService
if a bucket is provided in options parameterTransferTable
How did you test these changes?
(Please add a line here how the changes were tested)
Ran Storage integration test suite in local Android Studio
Documentation update required?
General Checklist
Added Unit TestsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.