Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storage): add integration tests for multi-bucket support #2900

Conversation

phantumcode
Copy link
Member

Multi-bucket support part 4

This the 4th and last part of a series of changes/pull request to support multi-bucket in the S3 Storage Plugin. The series of changes will be reviewed and merged into a feature branch and combined into a single pull request to be reviewed and merged into main branch.

For references:
part 1: #2895
part 2: #2896
part 3: #2899

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:

  • Add integration tests for providing a bucket option when executing Storage apis (list, remove, getUrl, download, and upload)
  • Update existing storage integration tests with teardown code to clean up test resources that were uploaded to S3
  • Fix missing code in AWSS3StoragePlugin that gets the AWSS3StorageService if a bucket is provided in options parameter
  • Minor spacing/formatting update in TransferTable

How did you test these changes?
(Please add a line here how the changes were tested)
Ran Storage integration test suite in local Android Studio

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Base automatically changed from phantum/storage-update-transfer-db to feature/storage_multi-bucket_support August 27, 2024 17:13
@phantumcode phantumcode merged commit 41c67d3 into feature/storage_multi-bucket_support Sep 4, 2024
@phantumcode phantumcode deleted the phantum/storage-multibucket-integ_test branch September 4, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants