Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): implement multiple buckets support #2904

Merged
merged 10 commits into from
Sep 17, 2024

Conversation

phantumcode
Copy link
Member

@phantumcode phantumcode commented Aug 27, 2024

  • PR title and description conform to Pull Request guidelines.

Issue #, if available:

Description of changes:
Adding multi-bucket support for Amplify Storage category/plugin.
All code changes have been previously reviewed and approved:

The following commit was made to fix formatting/lint errors, no functional code changes were made: 05b21e6

How did you test these changes?
Changes were manually tested, unit tested, and integration tested.

Documentation update required?

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 27.41935% with 225 lines in your changes missing coverage. Please review.

Project coverage is 43.96%. Comparing base (7f874ed) to head (de5fc34).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2904      +/-   ##
==========================================
- Coverage   44.01%   43.96%   -0.06%     
==========================================
  Files         926      931       +5     
  Lines       30485    30688     +203     
  Branches     4351     4377      +26     
==========================================
+ Hits        13419    13491      +72     
- Misses      15601    15728     +127     
- Partials     1465     1469       +4     

@phantumcode phantumcode marked this pull request as ready for review September 6, 2024 15:22
@phantumcode phantumcode requested review from a team as code owners September 6, 2024 15:22
@phantumcode phantumcode changed the title [DRAFT] feat(storage): add multi-bucket support feat(storage): implement multiple buckets support Sep 6, 2024
@phantumcode phantumcode merged commit 639ef96 into main Sep 17, 2024
3 checks passed
@phantumcode phantumcode deleted the feature/storage_multi-bucket_support branch September 17, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants