-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): implement multiple buckets support #2904
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2904 +/- ##
==========================================
- Coverage 44.01% 43.96% -0.06%
==========================================
Files 926 931 +5
Lines 30485 30688 +203
Branches 4351 4377 +26
==========================================
+ Hits 13419 13491 +72
- Misses 15601 15728 +127
- Partials 1465 1469 +4 |
phantumcode
changed the title
[DRAFT] feat(storage): add multi-bucket support
feat(storage): implement multiple buckets support
Sep 6, 2024
mattcreaser
approved these changes
Sep 12, 2024
tylerjroach
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Adding multi-bucket support for Amplify Storage category/plugin.
All code changes have been previously reviewed and approved:
The following commit was made to fix formatting/lint errors, no functional code changes were made: 05b21e6
How did you test these changes?
Changes were manually tested, unit tested, and integration tested.
Documentation update required?
General Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.