Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(go-function-runtime-provider): fix build go error #13659

Conversation

MarlonJD
Copy link

@MarlonJD MarlonJD commented Mar 19, 2024

Description of changes

I changed object name to bootstrap and runtime replaced to provided.al2023 from go1.x. because of the end of support in AWS Lambda. I tested on my local machine, added new function then push, tested lambda functions, it works.

Issue #, if available

#13658

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@MarlonJD MarlonJD requested a review from a team as a code owner March 19, 2024 00:11
@MarlonJD MarlonJD closed this Mar 19, 2024
@MarlonJD MarlonJD force-pushed the go-function-runtime-provider/fix-build-go-error branch from 059fba1 to db6b2d1 Compare March 19, 2024 02:20
@MarlonJD MarlonJD reopened this Mar 19, 2024
@MarlonJD MarlonJD force-pushed the go-function-runtime-provider/fix-build-go-error branch from 4b6f1a2 to 5ffe8c4 Compare March 23, 2024 16:15
@hunterhug
Copy link

Wating for this PR. Now use amplify with golang function is so inconvenience.

@MarlonJD
Copy link
Author

@0618 Do you want to add changes for windows and test related changes that you did before on draft pr #13671 ?

@MarlonJD
Copy link
Author

MarlonJD commented Apr 6, 2024

#13671 has merged, so this PR no need to be open anymore. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants