Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade Go runtime and fix e2e #13671

Merged
merged 17 commits into from
Apr 4, 2024
Merged

fix: upgrade Go runtime and fix e2e #13671

merged 17 commits into from
Apr 4, 2024

Conversation

0618
Copy link
Contributor

@0618 0618 commented Mar 25, 2024

Description of changes

  • Fixed some linting errors
  • l_function_3a_init_special_case_http_migration failure is caused by the outdated Go runtime

The runtime parameter of go1.x is no longer supported for creating or updating AWS Lambda functions. We recommend you use the new runtime (provided.al2023) while creating or updating functions.

To solve the error, this PR does the following:
- split l_function_3a_init_special_case_http_migration into 6 tests --> function_3a (python, dotnet, Go, nodejs), special_case, http_migration
- upgrade to al2023 https://github.com/aws/aws-lambda-go

ref:

Issue #, if available

#13658

Description of how you validated changes

  • Tested on local machine (yarn e2e <TEST>)
  • Tested on Cloud (PR check)

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@0618 0618 changed the title fix: e2e l_diagnose_hooks_a_mock_api fix: upgrade Go runtime and fix e2e Mar 27, 2024
@0618 0618 marked this pull request as ready for review April 3, 2024 15:47
@0618 0618 requested a review from a team as a code owner April 3, 2024 15:47
sobolk
sobolk previously approved these changes Apr 3, 2024
sobolk
sobolk previously approved these changes Apr 3, 2024
@0618 0618 merged commit 395f717 into aws-amplify:dev Apr 4, 2024
5 of 6 checks passed
@0618 0618 deleted the fix-e2e branch April 18, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants