fix: migrate useAuth hook for v6 #1137
Merged
+206
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1137 +/- ##
=======================================
Coverage 93.85% 93.86%
=======================================
Files 149 150 +1
Lines 6104 6112 +8
Branches 1834 1836 +2
=======================================
+ Hits 5729 5737 +8
Misses 357 357
Partials 18 18
Continue to review full report in Codecov by Sentry.
|
letsbelopez
commented
Nov 22, 2023
packages/codegen-ui-react/lib/__tests__/__snapshots__/studio-ui-codegen-react.test.ts.snap
Show resolved
Hide resolved
letsbelopez
commented
Nov 22, 2023
packages/codegen-ui-react/lib/__tests__/__snapshots__/studio-ui-codegen-react.test.ts.snap
Show resolved
Hide resolved
letsbelopez
commented
Nov 22, 2023
packages/codegen-ui-react/lib/utils-file-functions/hooks/useAuth.ts
Outdated
Show resolved
Hide resolved
awinberg-aws
approved these changes
Nov 22, 2023
Jshhhh
approved these changes
Nov 22, 2023
letsbelopez
added a commit
that referenced
this pull request
Nov 27, 2023
* fix: migrate useAuth hook for v6 * fix: remove console log --------- Co-authored-by: David Lopez <lopezbnd@amazon.com>
letsbelopez
added a commit
that referenced
this pull request
Nov 29, 2023
* fix: init v6 integ tests * fix: migrate useAuth hook for v6 (#1137) * fix: migrate useAuth hook for v6 * fix: remove console log --------- Co-authored-by: David Lopez <lopezbnd@amazon.com> * fix: v6 broken integ tests * chore: put v5 and v6 test templates in separate packages * fix: pin ts to 4.4.4 for integ tests * fix: add no-ci flag to integ v6 * fix: import Amplify * fix: add mock exports * fix: update templates back to test-generator package * fix: remove new integ test packages * fix: menu test * fix: rename v5 test template * fix: v5 integ tests remove view and tabs primitive --------- Co-authored-by: David Lopez <lopezbnd@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We need to migrate the useAuth hook for v6
Solution
Migrate it over
Additional Notes
Links
Ticket
GitHub issue:
Other links
Verification
Manual tests
Automated tests
Housekeeping
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.