Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V6 integ tests #1138

Merged
merged 13 commits into from
Nov 29, 2023
Merged

V6 integ tests #1138

merged 13 commits into from
Nov 29, 2023

Conversation

letsbelopez
Copy link
Contributor

@letsbelopez letsbelopez commented Nov 27, 2023

Problem

We need a separate integ template for v6 to address the api changes.

Solution

Create the new template

Additional Notes

Links

Ticket

GitHub issue:

Other links

Verification

Manual tests

Automated tests

  • Unit tests added/updated
  • E2E tests added/updated
  • N/A - (provide a reason)
  • deferred - (provide GitHub issue for tracking)

Housekeeping

  • No non-essential console logs
  • All new files contain license notice

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

David Lopez and others added 3 commits November 20, 2023 13:40
* fix: migrate useAuth hook for v6

* fix: remove console log

---------

Co-authored-by: David Lopez <lopezbnd@amazon.com>
@letsbelopez letsbelopez requested a review from a team as a code owner November 27, 2023 23:16
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2023

Codecov Report

Merging #1138 (70c876e) into main (69ece2f) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1138   +/-   ##
=======================================
  Coverage   93.85%   93.86%           
=======================================
  Files         149      150    +1     
  Lines        6104     6112    +8     
  Branches     1834     1836    +2     
=======================================
+ Hits         5729     5737    +8     
  Misses        357      357           
  Partials       18       18           
Files Coverage Δ
...ges/codegen-ui-react/lib/imports/import-mapping.ts 100.00% <100.00%> (ø)
...gen-ui-react/lib/react-studio-template-renderer.ts 93.65% <100.00%> (+0.03%) ⬆️
...-react/lib/react-utils-studio-template-renderer.ts 96.07% <100.00%> (+0.16%) ⬆️
...n-ui-react/lib/utils-file-functions/hooks/index.ts 100.00% <100.00%> (ø)
...ui-react/lib/utils-file-functions/hooks/useAuth.ts 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69ece2f...70c876e. Read the comment docs.

@letsbelopez letsbelopez merged commit 9943316 into main Nov 29, 2023
11 checks passed
@letsbelopez letsbelopez deleted the v6IntegTests branch November 29, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants