fix: remove e2e test account credentials #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hein-j
previously approved these changes
Jan 5, 2023
Milan-Shah
previously approved these changes
Jan 5, 2023
letsbelopez
force-pushed
the
removeTestAccountCredentials
branch
6 times, most recently
from
092e222 to
03a708d
Compare
Milan-Shah
previously approved these changes
Jan 6, 2023
Codecov Report
@@ Coverage Diff @@
## main #875 +/- ##
=======================================
Coverage 92.78% 92.78%
=======================================
Files 115 115
Lines 4853 4853
Branches 1404 1404
=======================================
Hits 4503 4503
Misses 330 330
Partials 20 20 Continue to review full report at Codecov.
|
letsbelopez
force-pushed
the
removeTestAccountCredentials
branch
2 times, most recently
from
ea70548 to
edce326
Compare
Milan-Shah
previously approved these changes
Jan 9, 2023
hein-j
previously approved these changes
Jan 9, 2023
letsbelopez
force-pushed
the
removeTestAccountCredentials
branch
from
edce326 to
896ebd9
Compare
hein-j
approved these changes
Jan 9, 2023
lyonsbp
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
https://app.asana.com/0/1203493556028707/1203510624767048/f
Description of changes:
Removes the e2e test account credentials and uses github oidc and aws account integration instead.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.