Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove e2e test account credentials #875

Merged
merged 1 commit into from
Jan 9, 2023
Merged

fix: remove e2e test account credentials #875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 27 additions & 8 deletions .github/workflows/canaries.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,17 +31,26 @@ jobs:
run: |
npm i aws-amplify @aws-amplify/ui-react
npm i --save-dev cypress
- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v1
with:
role-to-assume: ${{ secrets.E2E_TEST_ROLE_ARN }}
aws-region: us-west-2
- name: Create temp AWS credentials file
working-directory: e2e-test-app
run: |
aws configure set aws_access_key_id $AWS_ACCESS_KEY_ID && \
aws configure set aws_secret_access_key $AWS_SECRET_ACCESS_KEY && \
aws configure set aws_session_token $AWS_SESSION_TOKEN && \
aws configure set default.region $AWS_REGION
- name: Run CLI Pull in test app
working-directory: e2e-test-app
run: |
FORCE_RENDER=1 amplify pull --appId ${{ secrets.E2E_TEST_APP_ID }} --envName staging -y --providers "{\
\"awscloudformation\":{\
\"configLevel\":\"project\",\
\"useProfile\":false,\
\"useProfile\":true,\
\"profileName\":\"default\",\
\"accessKeyId\":\"${{ secrets.E2E_TEST_ACCESS_KEY }}\",\
\"secretAccessKey\":\"${{ secrets.E2E_TEST_SECRET_KEY }}\",\
\"region\":\"us-west-2\"\
}\
}"
- name: Write test files
Expand Down Expand Up @@ -103,17 +112,26 @@ jobs:
run: |
npm i aws-amplify @aws-amplify/ui-react
npm i --save-dev cypress
- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v1
with:
role-to-assume: ${{ secrets.E2E_TEST_ROLE_ARN }}
aws-region: us-west-2
- name: Create temp AWS credentials file
working-directory: e2e-test-app
run: |
aws configure set aws_access_key_id $AWS_ACCESS_KEY_ID && \
aws configure set aws_secret_access_key $AWS_SECRET_ACCESS_KEY && \
aws configure set aws_session_token $AWS_SESSION_TOKEN && \
aws configure set default.region $AWS_REGION
- name: Run CLI Pull in test app
working-directory: e2e-test-app
run: |
FORCE_RENDER=1 amplify pull --appId ${{ secrets.E2E_TEST_APP_ID }} --envName staging -y --providers "{\
\"awscloudformation\":{\
\"configLevel\":\"project\",\
\"useProfile\":false,\
\"useProfile\":true,\
\"profileName\":\"default\",\
\"accessKeyId\":\"${{ secrets.E2E_TEST_ACCESS_KEY }}\",\
\"secretAccessKey\":\"${{ secrets.E2E_TEST_SECRET_KEY }}\",\
\"region\":\"us-west-2\"\
}\
}"
- name: Write test files
Expand All @@ -131,6 +149,7 @@ jobs:
env:
REACT_APP_USER_EMAIL: ${{ secrets.E2E_TEST_USER_EMAIL }}
REACT_APP_USER_PASSWORD: ${{ secrets.E2E_TEST_USER_PASSWORD }}

write-release-canary-failure-metric:
runs-on: ubuntu-latest
needs: release-canary
Expand Down
22 changes: 18 additions & 4 deletions .github/workflows/check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,11 @@ on:
pull_request:
branches: [main, develop, feature/*, tagged-release/*]

# These permissions are needed to interact with GitHub's OIDC Token endpoint.
permissions:
id-token: write # This is required for requesting the JWT
contents: read # This is required for actions/checkout

jobs:
amplify-cli-tests:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -52,17 +57,26 @@ jobs:
run: |
npm i aws-amplify @aws-amplify/ui-react
npm i --save-dev cypress
- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v1
with:
role-to-assume: ${{ secrets.E2E_TEST_ROLE_ARN }}
aws-region: us-west-2
- name: Create temp AWS credentials file
working-directory: e2e-test-app
run: |
aws configure set aws_access_key_id $AWS_ACCESS_KEY_ID && \
aws configure set aws_secret_access_key $AWS_SECRET_ACCESS_KEY && \
aws configure set aws_session_token $AWS_SESSION_TOKEN && \
aws configure set default.region $AWS_REGION
- name: Run CLI Pull in test app
working-directory: e2e-test-app
run: |
FORCE_RENDER=1 amplify-dev pull --appId ${{ secrets.E2E_TEST_APP_ID }} --envName staging -y --providers "{\
\"awscloudformation\":{\
\"configLevel\":\"project\",\
\"useProfile\":false,\
\"useProfile\":true,\
\"profileName\":\"default\",\
\"accessKeyId\":\"${{ secrets.E2E_TEST_ACCESS_KEY }}\",\
\"secretAccessKey\":\"${{ secrets.E2E_TEST_SECRET_KEY }}\",\
\"region\":\"us-west-2\"\
}\
}"
- name: Write test files
Expand Down