Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api): add field to schema in provision script #1909

Merged
merged 1 commit into from
Aug 26, 2022
Merged

chore(api): add field to schema in provision script #1909

merged 1 commit into from
Aug 26, 2022

Conversation

ragingsquirrel3
Copy link
Contributor

API integration tests were failing. This was because they use codegen models from amplify_test package, where another field was added to the schema. The provisioned backend didn't have that field, so appsync was giving some errors when trying to include in a selection set (which the model helpers will do from codegen models). To fix it, you can just add that field to the backend. This PR adds in provision script so it will be fixed in any newly provisioned backend.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ragingsquirrel3 ragingsquirrel3 requested a review from a team as a code owner July 20, 2022 22:22
@codecov-commenter
Copy link

Codecov Report

Merging #1909 (2c9cbfa) into main (a88616f) will increase coverage by 2.75%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1909      +/-   ##
==========================================
+ Coverage   45.13%   47.88%   +2.75%     
==========================================
  Files         369      373       +4     
  Lines       10012    10863     +851     
==========================================
+ Hits         4519     5202     +683     
- Misses       5493     5661     +168     
Flag Coverage Δ
android-unit-tests ∅ <ø> (∅)
flutter-unit-tests 38.27% <ø> (ø)
ios-unit-tests 89.83% <ø> (-6.94%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
..._ios/example/ios/unit_tests/RestApiUnitTests.swift 85.16% <0.00%> (ø)
...plify_api_ios/example/ios/Runner/AppDelegate.swift 0.00% <0.00%> (ø)
...s/example/ios/unit_tests/GraphQLApiUnitTests.swift 89.50% <0.00%> (ø)
...xample/ios/unit_tests/FlutterURLSessionTests.swift 58.49% <0.00%> (ø)

@ragingsquirrel3 ragingsquirrel3 merged commit a05a170 into aws-amplify:main Aug 26, 2022
@ragingsquirrel3 ragingsquirrel3 deleted the chore/api-provision branch August 26, 2022 23:36
HuiSF pushed a commit to HuiSF/amplify-flutter that referenced this pull request Sep 19, 2022
HuiSF added a commit that referenced this pull request Sep 19, 2022
* chore(deps): bump file_picker from 4.6.1 to 5.0.1 in /example (#1944)

Bumps [file_picker](https://github.com/miguelpruivo/flutter_file_picker) from 4.6.1 to 5.0.1.
- [Release notes](https://github.com/miguelpruivo/flutter_file_picker/releases)
- [Changelog](https://github.com/miguelpruivo/flutter_file_picker/blob/master/CHANGELOG.md)
- [Commits](https://github.com/miguelpruivo/flutter_file_picker/commits)

---
updated-dependencies:
- dependency-name: file_picker
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jordan Nelson <nejrd@amazon.com>

* chore(auth): enable integration tests in CI (#1886)

* chore(repo): Update bug report to include deployment option (#1928)

Adds the following info to the bug report template:
- Whether the CLI or another mechanism was used to deploy their backend
- Their sanitized amplifyconfig

These both seem to provide a lot of insight and they can be missed in the conversation, especially the first one. We cannot assume that people filing issues are using pristine Amplify-generated backends.

* feat(authenticator): listen to all auth hub events (#2053)

* feat: listen to hub events

* chore: wait for config completion to listen to hub

* chore(api): add field to schema in provision script (#1909)

* fix(core): Podspec deployment target (#2099)

Fixes an issue surfaced in Flutter 3.3.0 which configures XCode projects based off this value. Previously, if the value was <9, the logic would apply. Now if the value is <11, the logic applies. We don't want this logic to apply.

The previous value was incorrect anyway so it's a good change to make regardless.

* chore(core): Export `safePrint` from amplify_core

And, by extension `amplify_flutter` which already exports `amplify_core`. This aligns the exports with `next`.

Fixes #2092.

commit-id:4afa07da

* fix(storage): Download to existing file

Fixes #2105.

Fixes an issue where downloading to an existing file will not work on iOS. For whatever reason, it will report progress and success, but will ultimately not overwrite the contents of the file.

commit-id:157d4ea3

* chore(storage): Update dependencies

commit-id:fa7c4c42

* chore(storage): Download to temp file

First downloads to a non-existent file, then copies the file to the location of the original in order to avoid iOS restrictions on overwriting data and potential failures which would result in deletion of the original file.

commit-id:7fbfb559

* fix(datastore): cpk errors on a custom type (#2134)

* chore: adds platform/category table (#2115)

* chore: adds platform/category table

* added dev preview matrix to amplify-flutter + root README; removed from package READMEs

Co-authored-by: Dustin Noyes <dnnoyes@amazon.com>

* chore(version): 0.6.8

* ad PR numbers to changelogs

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jordan Nelson <nejrd@amazon.com>
Co-authored-by: Travis Sheppard <tshepp@amazon.com>
Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com>
Co-authored-by: Dillon Nys <nydillon@amazon.com>
Co-authored-by: Dustin Noyes <dustin.noyes.dev@gmail.com>
Co-authored-by: Dustin Noyes <dnnoyes@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants