fix(core): Podspec deployment target #2099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue surfaced in Flutter 3.3.0 which configures XCode projects based off this value. Previously, if the value was <9, the logic would apply. Now if the value is <11, the logic applies. We don't want this logic to apply. The previous value was incorrect anyway so it's a good change to make regardless. commit-id:09660e38
salihgueler
approved these changes
Sep 7, 2022
HuiSF
approved these changes
Sep 7, 2022
ragingsquirrel3
approved these changes
Sep 7, 2022
haverchuck
approved these changes
Sep 7, 2022
dnys1
added a commit
to dnys1/amplify-flutter
that referenced
this pull request
Sep 7, 2022
Fixes an issue surfaced in Flutter 3.3.0 which configures XCode projects based off this value. Previously, if the value was <9, the logic would apply. Now if the value is <11, the logic applies. We don't want this logic to apply. The previous value was incorrect anyway so it's a good change to make regardless.
dnys1
added a commit
that referenced
this pull request
Sep 8, 2022
Fixes an issue surfaced in Flutter 3.3.0 which configures XCode projects based off this value. Previously, if the value was <9, the logic would apply. Now if the value is <11, the logic applies. We don't want this logic to apply. The previous value was incorrect anyway so it's a good change to make regardless.
HuiSF
pushed a commit
to HuiSF/amplify-flutter
that referenced
this pull request
Sep 19, 2022
Fixes an issue surfaced in Flutter 3.3.0 which configures XCode projects based off this value. Previously, if the value was <9, the logic would apply. Now if the value is <11, the logic applies. We don't want this logic to apply. The previous value was incorrect anyway so it's a good change to make regardless.
HuiSF
added a commit
that referenced
this pull request
Sep 19, 2022
* chore(deps): bump file_picker from 4.6.1 to 5.0.1 in /example (#1944) Bumps [file_picker](https://github.com/miguelpruivo/flutter_file_picker) from 4.6.1 to 5.0.1. - [Release notes](https://github.com/miguelpruivo/flutter_file_picker/releases) - [Changelog](https://github.com/miguelpruivo/flutter_file_picker/blob/master/CHANGELOG.md) - [Commits](https://github.com/miguelpruivo/flutter_file_picker/commits) --- updated-dependencies: - dependency-name: file_picker dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jordan Nelson <nejrd@amazon.com> * chore(auth): enable integration tests in CI (#1886) * chore(repo): Update bug report to include deployment option (#1928) Adds the following info to the bug report template: - Whether the CLI or another mechanism was used to deploy their backend - Their sanitized amplifyconfig These both seem to provide a lot of insight and they can be missed in the conversation, especially the first one. We cannot assume that people filing issues are using pristine Amplify-generated backends. * feat(authenticator): listen to all auth hub events (#2053) * feat: listen to hub events * chore: wait for config completion to listen to hub * chore(api): add field to schema in provision script (#1909) * fix(core): Podspec deployment target (#2099) Fixes an issue surfaced in Flutter 3.3.0 which configures XCode projects based off this value. Previously, if the value was <9, the logic would apply. Now if the value is <11, the logic applies. We don't want this logic to apply. The previous value was incorrect anyway so it's a good change to make regardless. * chore(core): Export `safePrint` from amplify_core And, by extension `amplify_flutter` which already exports `amplify_core`. This aligns the exports with `next`. Fixes #2092. commit-id:4afa07da * fix(storage): Download to existing file Fixes #2105. Fixes an issue where downloading to an existing file will not work on iOS. For whatever reason, it will report progress and success, but will ultimately not overwrite the contents of the file. commit-id:157d4ea3 * chore(storage): Update dependencies commit-id:fa7c4c42 * chore(storage): Download to temp file First downloads to a non-existent file, then copies the file to the location of the original in order to avoid iOS restrictions on overwriting data and potential failures which would result in deletion of the original file. commit-id:7fbfb559 * fix(datastore): cpk errors on a custom type (#2134) * chore: adds platform/category table (#2115) * chore: adds platform/category table * added dev preview matrix to amplify-flutter + root README; removed from package READMEs Co-authored-by: Dustin Noyes <dnnoyes@amazon.com> * chore(version): 0.6.8 * ad PR numbers to changelogs Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jordan Nelson <nejrd@amazon.com> Co-authored-by: Travis Sheppard <tshepp@amazon.com> Co-authored-by: Dillon Nys <24740863+dnys1@users.noreply.github.com> Co-authored-by: Dillon Nys <nydillon@amazon.com> Co-authored-by: Dustin Noyes <dustin.noyes.dev@gmail.com> Co-authored-by: Dustin Noyes <dnnoyes@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2098.
Fixes an issue surfaced in Flutter 3.3.0 which configures XCode projects based off this value. Previously, if the value was <9, the logic would apply. Now if the value is <11, the logic applies. We don't want this logic to apply.
The previous value was incorrect anyway so it's a good change to make regardless.