fix(datastore): prevent unhandled exception crashing App rebuilding s… #2549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnys1
approved these changes
Jan 6, 2023
dnys1
previously approved these changes
Jan 6, 2023
| latch.await() | ||
| try { | ||
| latch.await() | ||
| } catch (e: InterruptedException) { |
There was a problem hiding this comment.
Is this the only exception we care about? Should this be catch (e: Exception)?
There was a problem hiding this comment.
Yea await throws only InterruptedException.
Jordan-Nelson
previously approved these changes
Jan 6, 2023
HuiSF
force-pushed
the
fix/ds-unhandled-exception-crash
branch
from
904c015 to
054ea68
Compare
HuiSF
force-pushed
the
fix/ds-unhandled-exception-crash
branch
from
054ea68 to
6464555
Compare
Codecov Report
@@ Coverage Diff @@
## main #2549 +/- ##
==========================================
+ Coverage 45.70% 46.01% +0.30%
==========================================
Files 360 364 +4
Lines 10926 11028 +102
==========================================
+ Hits 4994 5074 +80
- Misses 5932 5954 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dnys1
approved these changes
Jan 6, 2023
Jordan-Nelson
approved these changes
Jan 9, 2023
dnys1
pushed a commit
to dnys1/amplify-flutter
that referenced
this pull request
Jan 11, 2023
## Fixes - fix(datastore): prevent unhandled exception crashing App rebuilding sync expression (aws-amplify#2549) - fix(datastore): Upgrading from Datastore 0.6.1 to 0.6.8 causes Android app to crash (aws-amplify#2556) ## Cherry Picks - 160674d - 7121ebc - 957d6b4 - 5ec55b9 - 33df283 - 5ec023b - 51f5e56 - fab55ae - 6bd4182 - 6464555 - 2a7caae
Merged
dnys1
pushed a commit
to dnys1/amplify-flutter
that referenced
this pull request
Jan 11, 2023
## Fixes - fix(datastore): prevent unhandled exception crashing App rebuilding sync expression (aws-amplify#2549) - fix(datastore): Upgrading from Datastore 0.6.1 to 0.6.8 causes Android app to crash (aws-amplify#2556) ## Cherry Picks - 160674d - 7121ebc - 957d6b4 - 5ec55b9 - 33df283 - 5ec023b - 51f5e56 - fab55ae - 6bd4182 - 6464555 - 2a7caae
dnys1
pushed a commit
to dnys1/amplify-flutter
that referenced
this pull request
Jan 12, 2023
- fix(datastore): prevent unhandled exception crashing App rebuilding sync expression (aws-amplify#2549) - fix(datastore): Upgrading from Datastore 0.6.1 to 0.6.8 causes Android app to crash (aws-amplify#2556) - fix(api): model helpers use targetNames in schemas with CPK enabled (aws-amplify#2559) - 160674d - 7121ebc - 957d6b4 - 5ec55b9 - 33df283 - 5ec023b - 51f5e56 - fab55ae - 6bd4182 - 6464555 - 2a7caae - 809190c
dnys1
pushed a commit
that referenced
this pull request
Jan 12, 2023
- fix(datastore): prevent unhandled exception crashing App rebuilding sync expression (#2549) - fix(datastore): Upgrading from Datastore 0.6.1 to 0.6.8 causes Android app to crash (#2556) - fix(api): model helpers use targetNames in schemas with CPK enabled (#2559) - 160674d - 7121ebc - 957d6b4 - 5ec55b9 - 33df283 - 5ec023b - 51f5e56 - fab55ae - 6bd4182 - 6464555 - 2a7caae - 809190c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ync expression
Issue #, if available:
Related: #1816
Description of changes:
There is reported that a unhandled exception causes App to crash on Android while DataStore building sync expression for amplify-android implementation from Dart implementation. I haven't figure out why the latch await would be interrupted, at least we can handle this exception thrown from
latch.await()to prevent App from crashing.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.