fix(api): write null values in ModelMutations.create() unless owner field #2679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnys1
approved these changes
Feb 20, 2023
Comment on lines
326
to
327
| .where((authRule) => authRule.ownerField != null) | ||
| .map((authRule) => authRule.ownerField!) |
There was a problem hiding this comment.
Suggested change
| .where((authRule) => authRule.ownerField != null) | |
| .map((authRule) => authRule.ownerField!) | |
| .map((authRule) => authRule.ownerField) | |
| .whereType<String>() // or `whereNotNull()` from `package:collection` |
HuiSF
approved these changes
Feb 21, 2023
dnys1
pushed a commit
that referenced
this pull request
Mar 7, 2023
### Breaking Changes - chore(auth)!: Chain stack traces in state machine - chore(core)!: Chain stack traces for state machines - feat(api)!: custom primary key support for GraphQL model helpers ([#2606](#2606)) ### Fixes - fix(api): early call of Amplify creates wrong instance of AmplifyClass - fix(api): write null values in ModelMutations.create() unless owner field ([#2679](#2679)) - fix(auth): Await `signInUri` in Hosted UI platform ([#2706](#2706)) - fix(auth): Transform session expired exceptions ([#2688](#2688)) - fix(storage): GetUrl signing ### Features - feat(api): GraphQL Subscription Where Filter ([#2650](#2650)) - feat(aws_common): add openRead API for AWSFile - feat(storage): optimize part size for multipart upload - feat(storage): web implementation of transfer database using local storage ([#2631](#2631)) Updated-Components: aws_common, Amplify Flutter, Amplify Dart, Amplify UI, DB Common
dnys1
pushed a commit
that referenced
this pull request
Mar 7, 2023
### Breaking Changes - chore(auth)!: Chain stack traces in state machine - chore(core)!: Chain stack traces for state machines - feat(api)!: custom primary key support for GraphQL model helpers ([#2606](#2606)) ### Fixes - fix(api): early call of Amplify creates wrong instance of AmplifyClass - fix(api): write null values in ModelMutations.create() unless owner field ([#2679](#2679)) - fix(auth): Await `signInUri` in Hosted UI platform ([#2706](#2706)) - fix(auth): Transform session expired exceptions ([#2688](#2688)) - fix(storage): GetUrl signing ### Features - feat(api): GraphQL Subscription Where Filter ([#2650](#2650)) - feat(aws_common): add openRead API for AWSFile - feat(storage): optimize part size for multipart upload - feat(storage): web implementation of transfer database using local storage ([#2631](#2631)) Updated-Components: aws_common, Amplify Flutter, Amplify Dart, Amplify UI, DB Common
dnys1
pushed a commit
that referenced
this pull request
Mar 7, 2023
### Breaking Changes - chore(auth)!: Chain stack traces in state machine - chore(core)!: Chain stack traces for state machines - feat(api)!: custom primary key support for GraphQL model helpers ([#2606](#2606)) ### Fixes - fix(api): early call of Amplify creates wrong instance of AmplifyClass - fix(api): write null values in ModelMutations.create() unless owner field ([#2679](#2679)) - fix(auth): Await `signInUri` in Hosted UI platform ([#2706](#2706)) - fix(auth): Transform session expired exceptions ([#2688](#2688)) - fix(storage): GetUrl signing ### Features - feat(api): GraphQL Subscription Where Filter ([#2650](#2650)) - feat(aws_common): add openRead API for AWSFile - feat(storage): optimize part size for multipart upload - feat(storage): web implementation of transfer database using local storage ([#2631](#2631)) Updated-Components: aws_common, Amplify Flutter, Amplify Dart, Amplify UI, DB Common
dnys1
pushed a commit
that referenced
this pull request
Mar 7, 2023
### Breaking Changes - chore(auth)!: Chain stack traces in state machine - chore(core)!: Chain stack traces for state machines - feat(api)!: custom primary key support for GraphQL model helpers ([#2606](#2606)) ### Fixes - fix(api): early call of Amplify creates wrong instance of AmplifyClass - fix(api): write null values in ModelMutations.create() unless owner field ([#2679](#2679)) - fix(auth): Await `signInUri` in Hosted UI platform ([#2706](#2706)) - fix(auth): Transform session expired exceptions ([#2688](#2688)) - fix(storage): GetUrl signing ### Features - feat(api): GraphQL Subscription Where Filter ([#2650](#2650)) - feat(aws_common): add openRead API for AWSFile - feat(storage): optimize part size for multipart upload - feat(storage): web implementation of transfer database using local storage ([#2631](#2631)) Updated-Components: aws_common, Amplify Flutter, Amplify Dart, Amplify UI, DB Common
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has a correction for some logic recently changed in #2504. While the previous PR changed
ModelMutations.create()to no longer include any null values in the input object, this PR makes it so only owner fields with null values will be removed from input and other null values will remain.While removing null owner values is essential to fix the issue mentioned in #2492, removing all null fields from create has some consequences that are difficult for users to understand or predict. Such as:
.ne(null)will match newer versions with undefined values (the issue that was reported). While breaking changes in dev preview are expected, I don't think this change has been given proper thought/communication.ModelMutations.update()includes null values (impossible to determine if undefined or explicit null there), any model updated for any reason will have all nulls, no undefined fields. For a user, it would be confusing why their data is in 2 states from create/update when the model is in the same state.Ultimately, the issues is that the codegen models have no way to distinguish between explicit nulls and undefined. Without a solution at that level, this PR makes things more consistent while still preventing the originally reported issue of null values in owner fields.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.