fix(auth): Await signInUri in Hosted UI platform
#2706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @passsy! The method signature was very recently updated to return a Future. I will look into adding tests which verify this behavior. In the meantime, yes this is the correct fix :) |
dnys1
changed the title
signInUri in Hosted UI platform
NikaHsn
approved these changes
Feb 28, 2023
ragingsquirrel3
approved these changes
Mar 1, 2023
Fixes #2705
Verifies the behavior of the `NativeAuthBridge` layer in the Hosted UI platform
dnys1
pushed a commit
that referenced
this pull request
Mar 7, 2023
### Breaking Changes - chore(auth)!: Chain stack traces in state machine - chore(core)!: Chain stack traces for state machines - feat(api)!: custom primary key support for GraphQL model helpers ([#2606](#2606)) ### Fixes - fix(api): early call of Amplify creates wrong instance of AmplifyClass - fix(api): write null values in ModelMutations.create() unless owner field ([#2679](#2679)) - fix(auth): Await `signInUri` in Hosted UI platform ([#2706](#2706)) - fix(auth): Transform session expired exceptions ([#2688](#2688)) - fix(storage): GetUrl signing ### Features - feat(api): GraphQL Subscription Where Filter ([#2650](#2650)) - feat(aws_common): add openRead API for AWSFile - feat(storage): optimize part size for multipart upload - feat(storage): web implementation of transfer database using local storage ([#2631](#2631)) Updated-Components: aws_common, Amplify Flutter, Amplify Dart, Amplify UI, DB Common
dnys1
pushed a commit
that referenced
this pull request
Mar 7, 2023
### Breaking Changes - chore(auth)!: Chain stack traces in state machine - chore(core)!: Chain stack traces for state machines - feat(api)!: custom primary key support for GraphQL model helpers ([#2606](#2606)) ### Fixes - fix(api): early call of Amplify creates wrong instance of AmplifyClass - fix(api): write null values in ModelMutations.create() unless owner field ([#2679](#2679)) - fix(auth): Await `signInUri` in Hosted UI platform ([#2706](#2706)) - fix(auth): Transform session expired exceptions ([#2688](#2688)) - fix(storage): GetUrl signing ### Features - feat(api): GraphQL Subscription Where Filter ([#2650](#2650)) - feat(aws_common): add openRead API for AWSFile - feat(storage): optimize part size for multipart upload - feat(storage): web implementation of transfer database using local storage ([#2631](#2631)) Updated-Components: aws_common, Amplify Flutter, Amplify Dart, Amplify UI, DB Common
dnys1
pushed a commit
that referenced
this pull request
Mar 7, 2023
### Breaking Changes - chore(auth)!: Chain stack traces in state machine - chore(core)!: Chain stack traces for state machines - feat(api)!: custom primary key support for GraphQL model helpers ([#2606](#2606)) ### Fixes - fix(api): early call of Amplify creates wrong instance of AmplifyClass - fix(api): write null values in ModelMutations.create() unless owner field ([#2679](#2679)) - fix(auth): Await `signInUri` in Hosted UI platform ([#2706](#2706)) - fix(auth): Transform session expired exceptions ([#2688](#2688)) - fix(storage): GetUrl signing ### Features - feat(api): GraphQL Subscription Where Filter ([#2650](#2650)) - feat(aws_common): add openRead API for AWSFile - feat(storage): optimize part size for multipart upload - feat(storage): web implementation of transfer database using local storage ([#2631](#2631)) Updated-Components: aws_common, Amplify Flutter, Amplify Dart, Amplify UI, DB Common
dnys1
pushed a commit
that referenced
this pull request
Mar 7, 2023
### Breaking Changes - chore(auth)!: Chain stack traces in state machine - chore(core)!: Chain stack traces for state machines - feat(api)!: custom primary key support for GraphQL model helpers ([#2606](#2606)) ### Fixes - fix(api): early call of Amplify creates wrong instance of AmplifyClass - fix(api): write null values in ModelMutations.create() unless owner field ([#2679](#2679)) - fix(auth): Await `signInUri` in Hosted UI platform ([#2706](#2706)) - fix(auth): Transform session expired exceptions ([#2688](#2688)) - fix(storage): GetUrl signing ### Features - feat(api): GraphQL Subscription Where Filter ([#2650](#2650)) - feat(aws_common): add openRead API for AWSFile - feat(storage): optimize part size for multipart upload - feat(storage): web implementation of transfer database using local storage ([#2631](#2631)) Updated-Components: aws_common, Amplify Flutter, Amplify Dart, Amplify UI, DB Common
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2705
I don't think this ever worked. The URL always resolved to
"Instance of 'Future<Uri>'"