Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(amplify_auth_cognito): initial commit for amplify_auth_cognito and amplify_auth_plugin_interface #3

Merged
merged 65 commits into from
Jul 31, 2020

Conversation

haverchuck
Copy link
Member

@haverchuck haverchuck commented Jul 7, 2020

Description of changes:
This PR includes amplify_auth_plugin_interface and the amplify_auth_cognito plugin, as well as changes needed for core. The plugin includes implementation of signUp, which should handle custom attributes, and email/phone number signup.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@Amplifiyer Amplifiyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Couple of minor questions but good to go 🚀

@haverchuck haverchuck merged commit 3bf1d91 into aws-amplify:master Jul 31, 2020
dnys1 added a commit that referenced this pull request Jul 22, 2022
Before

```
flutter: ERROR | SignUpStateMachine | Emitted error
flutter: ERROR | Authenticator | Error in AuthBloc
```

After

```
flutter: ERROR | SignUpStateMachine | Emitted error: InvalidParameterException [Attributes did not conform to the schema: email: The attribute is required, null, null]
#0      HttpOperation.deserializeOutput
package:smithy/…/http/http_operation.dart:278
<asynchronous suspension>
#1      AWSRetryer.retry
package:smithy_aws/…/retry/aws_retryer.dart:160
<asynchronous suspension>
#2      WrappedCognitoIdentityProviderClient.signUp
package:amplify_auth_cognito_dart/…/sdk/sdk_bridge.dart:516
<asynchronous suspension>
#3      SignUpStateMachine.onInitiate
package:amplify_auth_cognito_dart/…/machines/sign_up_state_machine.dart:42
<asynchronous suspension>
#4      SignUpStateMachineBase.resolve
package:amplify_auth_cognito_dart/…/generated/sign_up_state_machine_base.dart:39
<asynchronous suspension>
#5      StateMachine._listenForEvents
package:amplify_core/…/state_machine/state_machine.dart:171
<asynchronous suspension>
flutter: ERROR | Authenticator | Error in AuthBloc: InvalidParameterException [Attributes did not conform to the schema: email: The attribute is required, null, null]
```
dnys1 added a commit to dnys1/amplify-flutter that referenced this pull request Jul 25, 2022
* fix(smithy): Join paths using forward slashes only

* Remove path import
dnys1 added a commit to dnys1/amplify-flutter that referenced this pull request Jul 28, 2022
* fix(smithy): Join paths using forward slashes only

* Remove path import
dnys1 added a commit to dnys1/amplify-flutter that referenced this pull request Jul 28, 2022
* fix(smithy): Join paths using forward slashes only

* Remove path import
@mrks89 mrks89 mentioned this pull request Jan 7, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants