fix(auth): Crash with EXC_BAD_ACCESS #3657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds checks to results of `IOServiceGetMatchingService` and `IORegistryEntryCreateCFProperty` FFI calls to prevent trying to access bad data in cast or free calls.
dnys1
force-pushed
the
fix/auth/bad-access-crash
branch
from
3088b11 to
8adf598
Compare
Jordan-Nelson
approved these changes
Aug 31, 2023
Equartey
approved these changes
Sep 1, 2023
dnys1
added a commit
that referenced
this pull request
Sep 11, 2023
fix(auth): Crash with `EXC_BAD_ACCESS` Adds checks to results of `IOServiceGetMatchingService` and `IORegistryEntryCreateCFProperty` FFI calls to prevent trying to access bad data in cast or free calls.
dnys1
pushed a commit
that referenced
this pull request
Sep 11, 2023
### Fixes - fix(auth): Crash with EXC_BAD_ACCESS ([#3657](#3657)) - fix(auth): Custom auth with device tracking, no SRP ([#3652](#3652)) - fix(auth): Uncaught Hosted UI cancellation ([#3686](#3686)) - fix: removed trailing slash at the end of uri ([#3626](#3626)) Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
dnys1
added a commit
that referenced
this pull request
Sep 11, 2023
fix(auth): Crash with `EXC_BAD_ACCESS` Adds checks to results of `IOServiceGetMatchingService` and `IORegistryEntryCreateCFProperty` FFI calls to prevent trying to access bad data in cast or free calls.
dnys1
pushed a commit
that referenced
this pull request
Sep 11, 2023
### Fixes - fix(auth): Crash with EXC_BAD_ACCESS ([#3657](#3657)) - fix(auth): Custom auth with device tracking, no SRP ([#3652](#3652)) - fix(auth): Uncaught Hosted UI cancellation ([#3686](#3686)) - fix: removed trailing slash at the end of uri ([#3626](#3626)) Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IOServiceGetMatchingServiceandIORegistryEntryCreateCFPropertyFFI calls to prevent trying to access bad data in cast or free calls.NSScreendue to potential ffigen bug