-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(version): Bump version #3725
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically, force a refresh. Some composite actions are failing due to stale credentials. https://github.com/aws-actions/configure-aws-credentials#unset-current-credentials
Adds some more e2e tests for the `updateMfaPreference` API
Bumps [actions/checkout](https://github.com/actions/checkout) from 3.5.3 to 3.6.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@c85c95e...f43a0e5) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…dcc4d0ba8eada7c08092aad5314 (#3603) Updates the requirements on [dart-lang/setup-dart](https://github.com/dart-lang/setup-dart) to permit the latest version. - [Release notes](https://github.com/dart-lang/setup-dart/releases) - [Changelog](https://github.com/dart-lang/setup-dart/blob/main/CHANGELOG.md) - [Commits](https://github.com/dart-lang/setup-dart/commits/e58aeb62aef51dcc4d0ba8eada7c08092aad5314) --- updated-dependencies: - dependency-name: dart-lang/setup-dart dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ckages/notifications/push/amplify_push_notifications/android (#3604) chore(deps): Bump org.mockito:mockito-core Bumps [org.mockito:mockito-core](https://github.com/mockito/mockito) from 5.4.0 to 5.5.0. - [Release notes](https://github.com/mockito/mockito/releases) - [Commits](mockito/mockito@v5.4.0...v5.5.0) --- updated-dependencies: - dependency-name: org.mockito:mockito-core dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ckages/amplify_datastore/android (#3602) chore(deps): Bump org.mockito:mockito-core Bumps [org.mockito:mockito-core](https://github.com/mockito/mockito) from 5.4.0 to 5.5.0. - [Release notes](https://github.com/mockito/mockito/releases) - [Commits](mockito/mockito@v5.4.0...v5.5.0) --- updated-dependencies: - dependency-name: org.mockito:mockito-core dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
feat(actions): Launch Android emulator
- Adds E2E workflows to `aft generate workflows` - Removes mono-workflow for E2E tests - Splits E2E workflows such that they run only when necessary - Adds concurrency settings to all workflows
Adds tests which encode the behavior around `resendUserAttributeConfirmationCode` with and without the `keepOriginal` properties enabled in Cognito.
* removed trailing slash at the end of gql uri * fix improved * chore: refactor getUri * chore: update test to include trailing slash --------- Co-authored-by: Jordan Nelson <Jordanryannelson@gmail.com>
* chore(deps): Bump process from 4.2.4 to 5.0.0 in /actions Bumps [process](https://github.com/google/process.dart) from 4.2.4 to 5.0.0. - [Release notes](https://github.com/google/process.dart/releases) - [Changelog](https://github.com/google/process.dart/blob/master/CHANGELOG.md) - [Commits](https://github.com/google/process.dart/commits) --- updated-dependencies: - dependency-name: process dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * chore(actions): Update process manager interface For conformance to `package:process` v5. --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dillon Nys <nydillon@amazon.com>
…dcc4d0ba8eada7c08092aad5314 (#3665) Updates the requirements on [dart-lang/setup-dart](https://github.com/dart-lang/setup-dart) to permit the latest version. - [Release notes](https://github.com/dart-lang/setup-dart/releases) - [Changelog](https://github.com/dart-lang/setup-dart/blob/main/CHANGELOG.md) - [Commits](https://github.com/dart-lang/setup-dart/commits/e58aeb62aef51dcc4d0ba8eada7c08092aad5314) --- updated-dependencies: - dependency-name: dart-lang/setup-dart dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Currently, `aft generate workflows` checks for the presence of a `workflow.yaml` file next to a `pubspec.yaml` to know if we should generate a GitHub action workflow or copy over the custom one. This leads to drift, though, since dependabot does not search these directories by default. We could update Dependabot to search these directories, but instead we add a setting to the aft config to say that the workflow which exists is custom and should not be overridden so that the information is not copied in two places.
The fix in #3558 assumed that device SRP would only be performed when password SRP had previously been performed as part of a custom Auth workflow. However, this is not true. In custom auth workflows without password SRP, device SRP can still be required when device tracking is enabled, and in this case it is not a requirement that password SRP have been previously performed.
fix(auth): Crash with `EXC_BAD_ACCESS` Adds checks to results of `IOServiceGetMatchingService` and `IORegistryEntryCreateCFProperty` FFI calls to prevent trying to access bad data in cast or free calls.
* chore(auth): Use `EventCompleter.ignore` instead of `unawaited` `unawaited` will still raise an error if there is one. By using `EventCompleter.ignore` we drop all completions, success or error. * fix(auth): Uncaught Hosted UI cancellation The HostedUIPlatform had a bug due to the fact that it both called `dispatcher.dispatchAndComplete` (which throws on failure states) and throwing a `UserCancelledException` which triggers a failure state. This lead to the error being thrown from `signInWithWebUI` and an uncaught exception being raised at the `dispatchAndComplete` call. This resolves the issue by only throwing from the HostedUiPlatform and letting the state machine resolving the cancellation. This also fixes an issue where `cancelSignIn` was never being called because the state machine was in a `signingIn` state at the time the cancellation was dispatched.
Force unwrapping nullable values is done in JS by calling `nullableValue.toString` which will throw an error if `nullableValue` is null. Browsers seem to handle this sort of error different than a thrown Dart error and the error is harder to trace when it happens. Introduces an `unwrapParameter` method to the base worker bee class so that unwrap errors are strongly-typed and provide more context to the issue.
Running heavy computations on the main thread in Web tests causes flaky behavior. Even on high performance computers, the interplay of the Dart runner, DDC, and browser engine causes frequent timeouts when blocking the main thread. Since these operations are tested elsewhere for Web in places where they are offloaded, skip them for Web.
Fixes flaky HostedUI test by updating expectations and not relying on the timings of the event loop.
ci(auth): Prevent eventual consistency issues
### Fixes - fix(auth): Crash with EXC_BAD_ACCESS ([#3657](#3657)) - fix(auth): Custom auth with device tracking, no SRP ([#3652](#3652)) - fix(auth): Uncaught Hosted UI cancellation ([#3686](#3686)) - fix: removed trailing slash at the end of uri ([#3626](#3626)) Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee
Equartey
approved these changes
Sep 11, 2023
Jordan-Nelson
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Updated-Components: amplify_lints, Amplify Flutter, Amplify Dart, Amplify UI, DB Common, Secure Storage, AWS Common, Smithy, Worker Bee