fix(authenticator): Wrap social button text #3692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnys1
force-pushed
the
fix/authenticator/social-button-text-overflow
branch
from
a1dc8d2 to
c87f345
Compare
8 tasks
Equartey
previously approved these changes
Sep 5, 2023
dnys1
force-pushed
the
fix/authenticator/social-button-text-overflow
branch
from
c87f345 to
a40f8ea
Compare
dnys1
changed the title
dnys1
force-pushed
the
fix/authenticator/social-button-text-overflow
branch
from
a40f8ea to
95f5d32
Compare
Equartey
previously approved these changes
Sep 8, 2023
Prevents overflow of social button text in constrained layouts by wrapping the text.
dnys1
force-pushed
the
fix/authenticator/social-button-text-overflow
branch
from
95f5d32 to
3269d8b
Compare
Equartey
previously approved these changes
Sep 8, 2023
packages/authenticator/amplify_authenticator/lib/src/widgets/social/social_button.dart
Show resolved
Hide resolved
| @@ -205,24 +217,32 @@ class _SocialSignInButtonState | |||
| builder: (context, constraints) { | |||
| final padding = calculatePadding(constraints); | |||
| return Padding( | |||
| padding: EdgeInsets.symmetric(horizontal: padding), | |||
| padding: EdgeInsets.symmetric( | |||
| vertical: 2, | |||
There was a problem hiding this comment.
I think this is increasing the height of the button. Is that what we want? It seems like the social buttons have a larger height than other buttons here: https://github.com/aws-amplify/amplify-flutter/pull/3692/files#diff-19731debe5953de4ce3baae91c6a663bf423a41677f989d42e1448b480a54353
Jordan-Nelson
approved these changes
Sep 14, 2023
Equartey
approved these changes
Sep 15, 2023
fjnoyp
pushed a commit
that referenced
this pull request
Sep 21, 2023
* fix(authenticator): Wrap social button text Prevents overflow of social button text in constrained layouts by wrapping the text. * Update padding * Update TODO
fjnoyp
pushed a commit
that referenced
this pull request
Sep 21, 2023
### Fixes - fix(aft): Constraints edge cases ([#3732](#3732)) - fix(authenticator): TOTP Setup typo ([#3758](#3758)) - fix(authenticator): Wrap social button text ([#3692](#3692)) - fix(authenticator): date validator ([#3766](#3766)) Updated-Components: amplify_datastore, amplify_analytics_pinpoint, amplify_auth_cognito, amplify_authenticator, aws_common, smithy, amplify_storage_s3_dart
Merged
fjnoyp
pushed a commit
that referenced
this pull request
Sep 21, 2023
* fix(authenticator): Wrap social button text Prevents overflow of social button text in constrained layouts by wrapping the text. * Update padding * Update TODO
fjnoyp
pushed a commit
that referenced
this pull request
Sep 21, 2023
### Fixes - fix(aft): Constraints edge cases ([#3732](#3732)) - fix(authenticator): TOTP Setup typo ([#3758](#3758)) - fix(authenticator): Wrap social button text ([#3692](#3692)) - fix(authenticator): date validator ([#3766](#3766)) Updated-Components: amplify_datastore, amplify_analytics_pinpoint, amplify_auth_cognito, amplify_authenticator, aws_common, smithy, amplify_storage_s3_dart
fjnoyp
pushed a commit
that referenced
this pull request
Sep 22, 2023
### Fixes - fix(aft): Constraints edge cases ([#3732](#3732)) - fix(authenticator): TOTP Setup typo ([#3758](#3758)) - fix(authenticator): Wrap social button text ([#3692](#3692)) - fix(authenticator): date validator ([#3766](#3766)) Updated-Components: amplify_datastore, amplify_analytics_pinpoint, amplify_auth_cognito, amplify_authenticator, aws_common, smithy, amplify_storage_s3_dart # Conflicts: # packages/amplify_datastore/CHANGELOG.md # packages/amplify_datastore/pubspec.yaml # packages/analytics/amplify_analytics_pinpoint_dart/CHANGELOG.md # packages/analytics/amplify_analytics_pinpoint_dart/lib/src/version.dart # packages/analytics/amplify_analytics_pinpoint_dart/pubspec.yaml # packages/auth/amplify_auth_cognito/CHANGELOG.md # packages/auth/amplify_auth_cognito/pubspec.yaml # packages/auth/amplify_auth_cognito_dart/CHANGELOG.md # packages/auth/amplify_auth_cognito_dart/pubspec.yaml # packages/authenticator/amplify_authenticator/CHANGELOG.md # packages/authenticator/amplify_authenticator/lib/src/version.dart # packages/authenticator/amplify_authenticator/pubspec.yaml # packages/storage/amplify_storage_s3_dart/CHANGELOG.md # packages/storage/amplify_storage_s3_dart/pubspec.yaml
dnys1
pushed a commit
that referenced
this pull request
Sep 25, 2023
### Fixes - fix(aft): Constraints edge cases ([#3732](#3732)) - fix(authenticator): TOTP Setup typo ([#3758](#3758)) - fix(authenticator): Wrap social button text ([#3692](#3692)) - fix(authenticator): date validator ([#3766](#3766)) Updated-Components: amplify_datastore, amplify_analytics_pinpoint, amplify_auth_cognito, amplify_authenticator, aws_common, smithy, amplify_storage_s3_dart # Conflicts: # packages/amplify_datastore/CHANGELOG.md # packages/amplify_datastore/pubspec.yaml # packages/analytics/amplify_analytics_pinpoint_dart/CHANGELOG.md # packages/analytics/amplify_analytics_pinpoint_dart/lib/src/version.dart # packages/analytics/amplify_analytics_pinpoint_dart/pubspec.yaml # packages/auth/amplify_auth_cognito/CHANGELOG.md # packages/auth/amplify_auth_cognito/pubspec.yaml # packages/auth/amplify_auth_cognito_dart/CHANGELOG.md # packages/auth/amplify_auth_cognito_dart/pubspec.yaml # packages/authenticator/amplify_authenticator/CHANGELOG.md # packages/authenticator/amplify_authenticator/lib/src/version.dart # packages/authenticator/amplify_authenticator/pubspec.yaml # packages/storage/amplify_storage_s3_dart/CHANGELOG.md # packages/storage/amplify_storage_s3_dart/pubspec.yaml Co-authored-by: kyle <kylechen@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent overflow of social button text in constrained layouts by shrinking the text to fit the available width.
Before
After