Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(authenticator): date validator #3766

Merged

Conversation

Jordan-Nelson
Copy link
Member

Issue #, if available: #3757

Description of changes:

  • Apply custom validators to date fields
  • Add test

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Jordan-Nelson Jordan-Nelson requested a review from a team as a code owner September 19, 2023 15:32
@Jordan-Nelson Jordan-Nelson merged commit 247962a into aws-amplify:main Sep 19, 2023
15 of 40 checks passed
@Jordan-Nelson Jordan-Nelson deleted the fix/authenticator-date-validator branch September 19, 2023 16:12
fjnoyp pushed a commit that referenced this pull request Sep 21, 2023
* fix: authenticator date validator

* chore: formatting

* chore: fix comment
fjnoyp pushed a commit that referenced this pull request Sep 21, 2023
### Fixes
- fix(aft): Constraints edge cases ([#3732](#3732))
- fix(authenticator): TOTP Setup typo ([#3758](#3758))
- fix(authenticator): Wrap social button text ([#3692](#3692))
- fix(authenticator): date validator ([#3766](#3766))

Updated-Components: amplify_datastore, amplify_analytics_pinpoint, amplify_auth_cognito, amplify_authenticator, aws_common, smithy, amplify_storage_s3_dart
@fjnoyp fjnoyp mentioned this pull request Sep 21, 2023
fjnoyp pushed a commit that referenced this pull request Sep 21, 2023
* fix: authenticator date validator

* chore: formatting

* chore: fix comment
fjnoyp pushed a commit that referenced this pull request Sep 21, 2023
### Fixes
- fix(aft): Constraints edge cases ([#3732](#3732))
- fix(authenticator): TOTP Setup typo ([#3758](#3758))
- fix(authenticator): Wrap social button text ([#3692](#3692))
- fix(authenticator): date validator ([#3766](#3766))

Updated-Components: amplify_datastore, amplify_analytics_pinpoint, amplify_auth_cognito, amplify_authenticator, aws_common, smithy, amplify_storage_s3_dart
fjnoyp pushed a commit that referenced this pull request Sep 22, 2023
### Fixes
- fix(aft): Constraints edge cases ([#3732](#3732))
- fix(authenticator): TOTP Setup typo ([#3758](#3758))
- fix(authenticator): Wrap social button text ([#3692](#3692))
- fix(authenticator): date validator ([#3766](#3766))

Updated-Components: amplify_datastore, amplify_analytics_pinpoint, amplify_auth_cognito, amplify_authenticator, aws_common, smithy, amplify_storage_s3_dart

# Conflicts:
#	packages/amplify_datastore/CHANGELOG.md
#	packages/amplify_datastore/pubspec.yaml
#	packages/analytics/amplify_analytics_pinpoint_dart/CHANGELOG.md
#	packages/analytics/amplify_analytics_pinpoint_dart/lib/src/version.dart
#	packages/analytics/amplify_analytics_pinpoint_dart/pubspec.yaml
#	packages/auth/amplify_auth_cognito/CHANGELOG.md
#	packages/auth/amplify_auth_cognito/pubspec.yaml
#	packages/auth/amplify_auth_cognito_dart/CHANGELOG.md
#	packages/auth/amplify_auth_cognito_dart/pubspec.yaml
#	packages/authenticator/amplify_authenticator/CHANGELOG.md
#	packages/authenticator/amplify_authenticator/lib/src/version.dart
#	packages/authenticator/amplify_authenticator/pubspec.yaml
#	packages/storage/amplify_storage_s3_dart/CHANGELOG.md
#	packages/storage/amplify_storage_s3_dart/pubspec.yaml
dnys1 pushed a commit that referenced this pull request Sep 25, 2023
### Fixes
- fix(aft): Constraints edge cases ([#3732](#3732))
- fix(authenticator): TOTP Setup typo ([#3758](#3758))
- fix(authenticator): Wrap social button text ([#3692](#3692))
- fix(authenticator): date validator ([#3766](#3766))

Updated-Components: amplify_datastore, amplify_analytics_pinpoint, amplify_auth_cognito, amplify_authenticator, aws_common, smithy, amplify_storage_s3_dart

# Conflicts:
#	packages/amplify_datastore/CHANGELOG.md
#	packages/amplify_datastore/pubspec.yaml
#	packages/analytics/amplify_analytics_pinpoint_dart/CHANGELOG.md
#	packages/analytics/amplify_analytics_pinpoint_dart/lib/src/version.dart
#	packages/analytics/amplify_analytics_pinpoint_dart/pubspec.yaml
#	packages/auth/amplify_auth_cognito/CHANGELOG.md
#	packages/auth/amplify_auth_cognito/pubspec.yaml
#	packages/auth/amplify_auth_cognito_dart/CHANGELOG.md
#	packages/auth/amplify_auth_cognito_dart/pubspec.yaml
#	packages/authenticator/amplify_authenticator/CHANGELOG.md
#	packages/authenticator/amplify_authenticator/lib/src/version.dart
#	packages/authenticator/amplify_authenticator/pubspec.yaml
#	packages/storage/amplify_storage_s3_dart/CHANGELOG.md
#	packages/storage/amplify_storage_s3_dart/pubspec.yaml

Co-authored-by: kyle <kylechen@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants